Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow decomposition: actually use specified provider for sensitivity analysis #61

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

sylvlecl
Copy link
Contributor

@sylvlecl sylvlecl commented Oct 4, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Small bugfix.

What is the current behavior? (You can also link to an open issue here)

In flow decomposition, the sensitivity provider actually used is not the one defined through the API, but the one from the platform config.
Encountered this issue in a context with 2 providers in the classpath (open loadflow, hades2), where it causes the failure of the computation because no default-impl is configured, while the configuration was not supposed to be used.

…analysis

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
@sylvlecl sylvlecl force-pushed the fix-sensi-runner-use branch from 8c79259 to 12b3c86 Compare October 4, 2022 15:37
@sylvlecl sylvlecl requested a review from OpenSuze October 4, 2022 15:37
@sylvlecl sylvlecl requested a review from phiedw October 4, 2022 16:15
@sylvlecl sylvlecl removed the request for review from phiedw October 4, 2022 16:16
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
@murgeyseb murgeyseb force-pushed the fix-sensi-runner-use branch from 0b593cd to 1a565db Compare October 7, 2022 10:15
This reverts commit f438166.

Signed-off-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
@murgeyseb murgeyseb force-pushed the fix-sensi-runner-use branch from 1a565db to 6b0dc43 Compare October 7, 2022 10:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@murgeyseb murgeyseb merged commit 0dcffa9 into main Oct 7, 2022
@murgeyseb murgeyseb deleted the fix-sensi-runner-use branch October 7, 2022 10:24
miovd pushed a commit that referenced this pull request Oct 7, 2022
…nalysis (#61)

* Flow decomposition: actually use configured provider for sensitivity analysis

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Co-authored-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Co-authored-by: Sébastien Murgey <sebastien.murgey@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants