Add scaling parameters to BalanceComputationParameters and adapt to core 5.2.0 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
changed the title
miovd
changed the title
miovd
changed the title
…ore 5.3.0-SNAPSHOT (prepare to 5.2.0) Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
miovd
force-pushed
the
add_scaling_parameters
branch
from
df1c93d to
9adc55f
Compare
|
SonarCloud Quality Gate failed. |
phiedw
reviewed
Mar 31, 2023
Comment on lines
121
to
+124
| private LoadFlowParameters loadFlowParameters = new LoadFlowParameters(); | ||
|
|
||
| private ScalingParameters scalingParameters = new ScalingParameters(); | ||
|
|
There was a problem hiding this comment.
Is there a reason to define these in the middle of the class rather than at the beginning?
There was a problem hiding this comment.
No, none, I just put it below LoadFlowParameters that was already there
annetill
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update to new Scalable API
Does this PR introduce a breaking change or deprecate an API? If yes, check the following: