Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network-map-viewer react component (extracted from gridsuite' gridstudy-app) #263

Merged
merged 8 commits into from
Dec 5, 2023
Merged

network-map-viewer react component (extracted from gridsuite' gridstudy-app) #263

merged 8 commits into from
Dec 5, 2023

Conversation

sylvlecl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature.

The goal is to extract from gridsuite a re-usable component for display of the network map view.

This will enable to use that same view in other applications, and for example to be able to bind it in jupyter notebooks.

The choice has been made to keep react at least for now as a dependency.

A goal is to move this, once validated, to either:

  • a dedicated repo in powsybl
  • better if possible: the powsybl-diagram-viewer repo

@CBiasuzzi
adds a network-map-viewer react component (extracted from gridsuite's…
c3b3ac2 
… gridstudy-app)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@sylvlecl sylvlecl requested review from jonenst and flo-dup May 24, 2023 08:40
@sylvlecl
Copy link
Contributor Author

@jonenst and @flo-dup : do not hesitate to transfer this for review to other relevant people.

Goals are to:

  • validate the approach, and in particular the way the component has been separated from its inputs
  • assess how it's possible to include this together with powsybl-diagram-viewer, where the packaging may be different, since there it's typescript language, and without react dependencies? (I really don't know the underlying technologies and if this can be an issue or not)

A companion branch on gridstudy-app repo should be open shortly, which includes the use of that component.

@CBiasuzzi
aligns to the latest network map's code, from the gridstudy-app
b32a81e 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CBiasuzzi
Copy link
Contributor

The PR (in WIP) for gridstudy-app's branch, which includes the use of the component: gridstudy-app 1323

@flomillot @jonenst
Update Node.js
72e596a 
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
@CBiasuzzi CBiasuzzi mentioned this pull request Nov 9, 2023
Merged
3 tasks
flomillot and others added 5 commits December 5, 2023 18:04
@flomillot @flo-dup
Update Node.js (#265)
fde43e1 
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@CBiasuzzi @flo-dup
aligned to the latest code from gridstudy-app
ce36448 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi @flo-dup
renames function to prevent names conflicts with forked code
ab6e410 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi @flo-dup
removes a no longer used dependency
058faa7 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi @flo-dup
fixes
ff65106 
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@flo-dup flo-dup force-pushed the network_map_viewer branch from e35d3cd to ff65106 Compare December 5, 2023 17:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@flo-dup
Copy link
Contributor

flo-dup commented Dec 5, 2023

I do merge this PR even though the problems highlighted by reviews of #267 are not solved, as I think they should rather be addressed in that other PR. Indeed, this is an incubator repository, plus merging this separates the work in two clear parts.

@flo-dup flo-dup merged commit 21bf83f into main Dec 5, 2023
6 checks passed
@flo-dup flo-dup deleted the network_map_viewer branch December 5, 2023 17:10
flo-dup pushed a commit that referenced this pull request Dec 5, 2023
@sylvlecl @flo-dup
network-map-viewer react component (extracted from gridsuite' gridstu…
90b0859 
…dy-app) (#263)

* adds a network-map-viewer react component (extracted from gridsuite's gridstudy-app)
* Update Node.js
* renames function to prevent names conflicts with forked code
* removes a no longer used dependency

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
flo-dup pushed a commit that referenced this pull request Dec 5, 2023
@sylvlecl @CBiasuzzi @flo-dup
network-map-viewer react component (extracted from gridsuite' gridstu…
58f6214 
…dy-app) (#263)

* adds a network-map-viewer react component (extracted from gridsuite's gridstudy-app)
* Update Node.js
* renames function to prevent names conflicts with forked code
* removes a no longer used dependency

Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Co-authored-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
flo-dup added a commit that referenced this pull request Apr 15, 2024
@flo-dup
Revert "network-map-viewer react component (extracted from gridsuite'…
28adb65 
… gridstudy-app) (#263)"

This reverts commit 58f6214.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup added a commit that referenced this pull request Apr 15, 2024
@flo-dup
Remove network map viewer (#269)
ff06347 
* Revert "Network map viewer built with Vite (#267)": This reverts commit f535583.
* Revert "network-map-viewer react component (extracted from gridsuite' gridstudy-app) (#263)": This reverts commit 58f6214.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonenst jonenst Awaiting requested review from jonenst

@flo-dup flo-dup Awaiting requested review from flo-dup

Assignees

@CBiasuzzi CBiasuzzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sylvlecl @CBiasuzzi @flo-dup @flomillot