Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage dangling lines and tie lines #172

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Manage dangling lines and tie lines #172

wants to merge 26 commits into from

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Sep 26, 2024 •
edited by jeandemanged
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature

What is the current behavior?
Tie lines are not managed and dangling lines are badly managed

What is the new behavior (if this is a feature change)?
Tie lines are managed like lines
Unpaired dangling lines are managed as line + load + generation. Note that the generation part (if present) is only added to the load part.

TieLines and DanglingLines can be used in contingencies and sections' branchList. Note that there is today a limitation in powsybl-core contingency DSL loader lacking support of TieLineContingency, will be resolved in powsybl/powsybl-core#3213

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@rolnico
add exception on Three Windings Transformers and Dangling Lines
f2f6927 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
remove dangling lines from branches (already managed as loads) + rewr…
ac3a84c 
…ite addElementToRetainedBreakersList to manage switches from BUS_BREAKER voltage levels + remove exception + add TODO on T3T

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
test exception on T3T
faa9170 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add test on MetrixNetwork
e10a1da 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
switch next to dangling lines should be managed as those next to loads
332dbd3 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
add more test for coverage
0a73685 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
Merge branch 'main' into nro/use_different_connectables
cd7c64b
@rolnico
remove useless comment
e219fc1 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
revert fixes on dangling line to do it in another PR
ccfa085 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico
manage dangling lines and tie lines
b46a26f 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico requested review from marifunf and olperr1 September 26, 2024 07:59
@rolnico rolnico self-assigned this Sep 26, 2024
@rolnico
add test for tieline coverage
e844ad8 
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@sonarqubecloud SonarQubeCloud

This comment was marked as outdated.

Sign in to view
@rolnico rolnico marked this pull request as ready for review September 27, 2024 07:20
@sonarqubecloud SonarQubeCloud

This comment was marked as outdated.

Sign in to view
@jeandemanged
Copy link
Member

Thanks
However, shouldn't unpaired DanglingLine model all this:

  • the "half-line" part
  • the load part
  • the optional generation part
    ?

@rolnico
Copy link
Member Author

rolnico commented Nov 7, 2024

Thanks However, shouldn't unpaired DanglingLine model all this:

* the "half-line" part

* the load part

* the optional generation part
  ?

Probably, yes!
I'll have to look at how to model this

@jeandemanged jeandemanged mentioned this pull request Nov 8, 2024
Merged
7 tasks
Base automatically changed from nro/use_different_connectables to main November 8, 2024 13:46
@jeandemanged
Merge branch 'refs/heads/main' into nro/dangline_lines_tie_lines
c322699 
# Conflicts:
#	metrix-integration/src/main/java/com/powsybl/metrix/integration/MetrixNetwork.java
#	metrix-integration/src/main/java/com/powsybl/metrix/integration/dataGenerator/MetrixInputData.java
#	metrix-integration/src/test/java/com/powsybl/metrix/integration/MetrixNetworkTest.java
@jeandemanged
Handle unpaired dangling line as quad + node + load
e923602 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged changed the title Manage dangling lines and tie lines [WIP] Manage dangling lines and tie lines Nov 8, 2024
@jeandemanged
test
c0d333f 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
DanglingLine BranchMonitoring
4afc31d 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
DanglingLine and TieLine Contingency
7de56fd 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
DanglingLine and TieLine Section Monitoring
b009460 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
Merge branch 'main' into nro/dangline_lines_tie_lines
5820fb8
@jeandemanged
clean
1ab3867 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
clean
7ce32a1 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
test
6c4e5aa 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
86.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jeandemanged jeandemanged changed the title [WIP] Manage dangling lines and tie lines Manage dangling lines and tie lines Nov 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marifunf marifunf Awaiting requested review from marifunf

@olperr1 olperr1 Awaiting requested review from olperr1

At least 1 approving review is required to merge this pull request.

Assignees

@rolnico rolnico

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolnico @jeandemanged