Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Add debug-nad folder into .powsybl to write debug files #74

Merged
merged 3 commits into from
May 20, 2022

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented May 13, 2022

Signed-off-by: Thomas ADAM tadam@silicom.fr

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Debug files are written at user home .powsybl folder

What is the new behavior (if this is a feature change)?
Debug files are written at user home .powsybl/debug-nad folder

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@tadam50 tadam50 requested a review from flo-dup May 13, 2022 13:03
@tadam50 tadam50 self-assigned this May 13, 2022
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the same changes as in PR powsybl/powsybl-diagram#392?

tadam50 added 3 commits May 20, 2022 09:25
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 force-pushed the add_debug_folder_into_.powsybl branch from 60fb920 to 413de1e Compare May 20, 2022 07:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit e1843d1 into main May 20, 2022
@flo-dup flo-dup deleted the add_debug_folder_into_.powsybl branch May 20, 2022 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants