This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Add metadata to enable moving nodes #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
|
Kudos, SonarCloud Quality Gate passed! |
flo-dup
suggested changes
Jul 22, 2022
There was a problem hiding this comment.
I'm wondering if after all it wouldn't be better to have tags in edges rather than in nodes. Indeed, each edge has only two node as attributes, so we could put those attribute in an empty xml element. It's less verbose than the other way around!
<nad:edge diagramId="x" equipmentId="z" node1="n1diagramId" node2="n2diagramId"/>
Nonetheless this would require a querySelectorAll in javascript to get the edges related to the clicked node.
What do you think?
| @@ -110,6 +110,394 @@ | |||
| } | |||
| ]]></style> | |||
| <metadata xmlns:nad="http://www.powsybl.org/schema/nad-metadata/1_0"> | |||
| <nad:voltageLevelNodes> | |||
There was a problem hiding this comment.
Why do you add a new tag? Couldn't the information be in the node tag?
3 tasks
|
Transferred into repository powsybl-diagram: powsybl/powsybl-diagram#448 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restpowsybl/powsybl-diagram#443
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)