Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds equipment information on problematic VSC and Busbar index #343

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Aug 1, 2023

Adds equipment information on problematic VSC and Busbar index in error messages.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Adds equipment information on problematic VSC and Busbar index in error messages.

What is the current behavior?

Thrown errors in busbar index do not have the faulty equipment ID.
Thrown errors in SVC do not have the faulty equipment ID.

What is the new behavior (if this is a feature change)?
Thrown errors in busbar index do have the faulty equipment ID.
Thrown errors in SVC do have the faulty equipment ID.

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

…or messages

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish EstherDarkish changed the title Adds equipment information on problematic VSC and Busbar index in err… [WIP] Adds equipment information on problematic VSC and Busbar index Aug 1, 2023
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish EstherDarkish changed the title [WIP] Adds equipment information on problematic VSC and Busbar index Adds equipment information on problematic VSC and Busbar index Aug 1, 2023
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
BOUTIER Charly and others added 2 commits August 16, 2023 11:54
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@EstherDarkish EstherDarkish merged commit 9bcf231 into main Aug 18, 2023
@EstherDarkish EstherDarkish deleted the add_equipment_id_in_throw_message branch August 18, 2023 14:06
jonenst pushed a commit that referenced this pull request Sep 22, 2023
…or messages (#343)

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants