Fix line overload color computation #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamal-khey/fix-map-lines-color-overload
branch
from
06401cb to
0d575af
Compare
antoinebhs
reviewed
Oct 31, 2024
| @@ -61,9 +61,10 @@ export function getLineLoadingZoneOfSide(limit, intensity, lineFlowAlertThreshol | |||
| return LineLoadingZone.UNKNOWN; | |||
| } else { | |||
| let threshold = (lineFlowAlertThreshold * limit) / 100; | |||
| if (intensity > 0 && intensity < threshold) { | |||
| const absoluteIntensity = Math.abs(intensity); | |||
| if (absoluteIntensity > 0 && absoluteIntensity < threshold) { | |||
There was a problem hiding this comment.
absolute intensity is always > 0 as we checked if intensity === 0 before
YenguiSeddik
approved these changes
Nov 7, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com>
|
souissimai
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
This PR fixes the function that computes the color of lines based on their overload status.
What kind of change does this PR introduce?
Bug fix: Corrects line coloring calculation by considering absolute values of line intensities
What is the current behavior?
The current implementation uses raw intensity values to determine line loading zones, which causes incorrect coloring when the intensity is negative. Negative values are being treated as overload when they should be treated based on their magnitude regardless of direction.
What is the new behavior (if this is a feature change)?
The fix uses the absolute value of the intensity (Math.abs(intensity)) when comparing against thresholds. This ensures that line loading zones are correctly calculated regardless of the current flow direction. For example, an intensity of -900A on a line with a 1000A limit will now properly show as being close to overload, whereas before it might have been incorrectly shown as safe.
Does this PR introduce a breaking change or deprecate an API?
Other information:
This fix ensures consistent line coloring behavior regardless of power flow direction
The change affects the visual representation only and does not impact any underlying calculations or data