-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename diagram-viewer into network-viewer #111
Conversation
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep powsybl-diagram-viewer as sonar project key ? We change it ?
Node from v18+ is required to build with Vite. | ||
|
||
Installation using npm: | ||
'npm install @powsybl/diagram-viewer' | ||
'npm install @powsybl/network-viewer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a procedure to rename an npm package ? We should find a way to make projects using @powsybl/diagram-viewer move to @powsybl/network-viewer I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you can't do that. But you could provide users with a deprecated message to tell them to use the new name: https://stackoverflow.com/questions/28371669/renaming-a-published-npm-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm deprecate my-project-name@"<= latest-version" "This project has been renamed. Install using new-project-name instead."
Co-authored-by: etiennehomer <etiennehomer@gmail.com> Signed-off-by: Florian Dupuy <66690739+flo-dup@users.noreply.github.com>
Right, we'd better change it. I'll change it in sonar, and then here. |
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Renaming
What is the current behavior?
powsybl-diagram-viewer
/@powsybl/diagram-viewer
What is the new behavior (if this is a feature change)?
powsybl-network-viewer
/@powsybl/network-viewer
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
'npm install @powsybl/network-viewer' instead of 'npm install @powsybl/diagram-viewer'