Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nad-viewer: fix calling move callback, fix boundary node moving #113

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

massimo-ferraro
Copy link
Contributor

@massimo-ferraro massimo-ferraro commented Nov 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
In network area diagram viewer,

  • when moving a node, the node metadata is not updated and the move node callback is not called
  • when moving a boundary node, the other node is not redrawn

What is the new behavior (if this is a feature change)?

  • when moving a node, the node metadata is updated and the move node callback is called
  • when moving a boundary node, the other node is redrawn

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Copy link

sonarqubecloud bot commented Nov 5, 2024

@flo-dup flo-dup changed the title Fix method for calling node move callback in network area diagram viewer nad-viewer: fix calling move callback, fix boundary node moving Nov 5, 2024
@flo-dup flo-dup merged commit 8bdd804 into main Nov 5, 2024
5 checks passed
@flo-dup flo-dup deleted the nad_fix_node_move_callback branch November 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants