locate substation with zoom #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamal-khey
force-pushed
the
jamalkhey/locate-substation-with-zoom
branch
from
c614a9d to
d23227c
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamalkhey/locate-substation-with-zoom
branch
from
d23227c to
dc5f44b
Compare
|
Maybe we need to check if the current zoom level is greater than the default zoom level defined in the code, and then consider the current zoom level. Otherwise, we should use the default one. |
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamalkhey/locate-substation-with-zoom
branch
from
1891533 to
26fd64b
Compare
Done , i keep the max between previous and new zoom level |
|
YenguiSeddik
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
centering the view on a substation did not trigger any zoom action on the substation. The camera may have remained at a default zoom level , making it difficult for users to focus on the specific substation they were trying to locate i a dense network
What is the new behavior (if this is a feature change)?
now when the location locating a substation, the camera automatically zooms in on the substation. This provides immediate visual feedback and helps users quickly identify the substation's location on the map.
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
a new optional props is available
locateSubStationZoomLevelwich allow to define zoom level.if not defined this props has a default value to 12