-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/typescript definitions build #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove extensions in imports * unecessary text block for glsl files * fix svg raw text to react components * unecessary vite-plugin-externalize-deps (out of sync with commons-ui) Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
> TS17004: Cannot use JSX unless the `--jsx` flag is provided. Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Tristan-WorkGH
force-pushed
the
fix/typescript-definitions-build
branch
from
July 16, 2024 08:47
e47cedc
to
ab4f667
Compare
Meklo
requested changes
Jul 17, 2024
Tristan-WorkGH
force-pushed
the
fix/typescript-definitions-build
branch
from
July 17, 2024 14:19
0c60d2a
to
bd04020
Compare
Meklo
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
What is the current behavior?What is the new behavior (if this is a feature change)?Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilledThe Breaking Change or Deprecated label has been addedThe migration steps are described in the following sectionWhat changes might users need to make in their application due to this PR? (migration steps)
As TypeScript resolve unknown entrypoint as
any
, maybe users using TypeScript might need to adjust a little the types.Other information:
Full list of changes:
.tgz
builds to .gitignore, to avoid accidental commits.d.ts
for exposed exportsunknown
because it ask too much time to find structure contentsrc/index
as it's only temporarytsconfig.json
(affect IDE introspection)import ... from ...
?raw
capability (permit to have file not embedded in a giant string in sources)