review comments

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>
powsybl · Mar 28, 2024 · 586cfe9 · 586cfe9
1 parent a6202a6
commit 586cfe9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/main/java/com/powsybl/openloadflow/network/impl/LfHvdcImpl.java b/src/main/java/com/powsybl/openloadflow/network/impl/LfHvdcImpl.java
@@ -46,12 +46,7 @@ public class LfHvdcImpl extends AbstractElement implements LfHvdc {
 
     private final double pMaxFromCS2toCS1;
 
-    public LfHvdcImpl(String id,
-                      LfBus bus1,
-                      LfBus bus2,
-                      LfNetwork network,
-                      HvdcLine hvdcLine,
-                      boolean acEmulation) {
+    public LfHvdcImpl(String id, LfBus bus1, LfBus bus2, LfNetwork network, HvdcLine hvdcLine, boolean acEmulation) {
         super(network);
         this.id = Objects.requireNonNull(id);
         this.bus1 = bus1;

diff --git a/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java b/src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java
@@ -517,16 +517,16 @@ void testAcEmuAndPMax() {
         assertTrue(result.isFullyConverged());
 
         // Active flow capped at limit. Output has losses (due to VSC stations)
-        assertEquals(170, network.getHvdcConverterStation("cs2").getTerminal().getP(), DELTA_POWER);
-        assertEquals(-166.280, network.getHvdcConverterStation("cs3").getTerminal().getP(), DELTA_POWER);
+        assertActivePowerEquals(170, network.getHvdcConverterStation("cs2").getTerminal());
+        assertActivePowerEquals(-166.280, network.getHvdcConverterStation("cs3").getTerminal());
 
         // now invert power direction
         HvdcAngleDroopActivePowerControl activePowerControl = network.getHvdcLine("hvdc23").getExtension(HvdcAngleDroopActivePowerControl.class);
         activePowerControl.setP0(-activePowerControl.getP0());
         result = loadFlowRunner.run(network, p);
         assertTrue(result.isFullyConverged());
 
-        assertEquals(-166.280, network.getHvdcConverterStation("cs2").getTerminal().getP(), DELTA_POWER);
-        assertEquals(170, network.getHvdcConverterStation("cs3").getTerminal().getP(), DELTA_POWER);
+        assertActivePowerEquals(-166.280, network.getHvdcConverterStation("cs2").getTerminal());
+        assertActivePowerEquals(170, network.getHvdcConverterStation("cs3").getTerminal());
     }
 }