Add reports in LfNetworkLoaderImpl #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caioluke please sign your commits and force push |
jeandemanged
requested changes
Apr 25, 2024
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
caioluke
force-pushed
the
add_reports_in_lfnetworkloaderimpl
branch
from
4ab844e to
ea8403a
Compare
jeandemanged
requested changes
Apr 29, 2024
src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Caio Luke <caioluke97@gmail.com>
caioluke
force-pushed
the
add_reports_in_lfnetworkloaderimpl
branch
from
a53116f to
95d3b20
Compare
caioluke
changed the title
# Conflicts: # src/test/java/com/powsybl/openloadflow/ac/GeneratorRemoteControlTest.java
jeandemanged
approved these changes
May 13, 2024
jeandemanged
requested changes
May 13, 2024
Signed-off-by: Caio Luke <caioluke97@gmail.com>
|
jeandemanged
approved these changes
May 15, 2024
geofjamg
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
The class LfNetworkLoaderImpl has a lot of information logged via the LOGGER, but the same information is not reported in the ReportNode API.
What is the new behavior (if this is a feature change)?
Important information will also be reported in the ReportNode API.
Does this PR introduce a breaking change or deprecate an API?