Improve transformer voltage control `AFTER_GNERATOR_VOLTAGE_CONTROL` #1032

vidaldid-rte · 2024-05-17T09:23:50Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
In order to provide a ratio tap change simulation that better matches our Network we introduce the following evolutions to the AfterVoltageControlOuterLoop:

Taps are not discretized before all taps are within their operating range. Instead, if a continuous ratio is outside of operating range, it is discretized at its limit and a loadflow is run again to update the continous ratios.
A new parameter ("transformerVoltageControlUseInitialTapPosition") minimize the tap changes in the following way:
- If the voltage of a bus of parallel tranformers is within range, the taps of the parallel transformers are not changed, even if they are not the closest tap to the continuous ratio.
- If the tap need to be changed but parallel transformers have different ratios initially, the difference is kept at discretization.
- This simulates the behavior of independent automates for parallel transformers. Additionally it can preserve some ration misalignment that could be done on purpose to consume some reactive power (due to a reactive current loop created by parallel transformers with misaligned ratios)
- If the mode is enabled, transformer that have no group controlling tension above them that is PV at computation time are excluded from tap computation.
The parameter "generatorVoltageControlMinNominalVoltage" (introduced in Fix transformer voltage control outer loop AFTER GENERATOR #1038 ) is used to define the nominal voltage below which generators are set to PQ while continuous ratio are computed.
Additionnally, generators that are just behind a step-up transformer that is above the limit continue to control voltage. This enable to support network models where generators are separated from the transformer connecting them to the network.

The default value of the new parameter (transformerVoltageControlUseInitialTapPosition) keep a behavior close to the previous behavior of TransformerVoltageControlOuterLoop.

What is the current behavior?

What is the new behavior (if this is a feature change)?
With current default of new parameters, almost same as before.
If transformerVoltageControlStable is set to true, simulation much closer to actual behaviour of our network.

Does this PR introduce a breaking change or deprecate an API?

Yes
No

What changes might users need to make in their application due to this PR? (migration steps)

…overage of new code Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

…hooting Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

jeandemanged

just a first rough diagonal review ... will look into it more in detail later on

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GroupVoltageControlManager.java

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/TransformerRatioManager.java

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

annetill

To start to talk!

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java

src/main/java/com/powsybl/openloadflow/ac/outerloop/TransformerVoltageControlOuterLoop.java

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GroupVoltageControlManager.java

annetill · 2024-06-11T12:17:31Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/TransformerVoltageControlOuterLoop.java

-        private double getMaxControlledNominalVoltage() {
-            return maxControlledNominalVoltage;
-        }
+        private GroupVoltageControlManager groupVoltageControlManager;


I understand that grouping transformer is not an option.

Renamed to GeneratorVoltageControlManager. Some French jumped in the initial name.

annetill · 2024-06-11T12:24:45Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GroupVoltageControlManager.java

+        }
+    }
+
+    private boolean isBusBehindVeryHighVoltageTransfo(LfBus bus, double limit) {


Do we really need this method? If the controlled bus is higher that the nominal voltage limit, is it not enough? Because this part is really specific and maybe works only for our network.

Must be void

annetill · 2024-06-11T12:28:23Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GroupVoltageControlManager.java

+/**
+ * @author Didier Vidal {@literal <didier.vidal-ext at rte-france.com>}
+ */
+public class GroupVoltageControlManager {


I don't understand why you need a dedicated class for that, and with Group inside the name: I don't see the link with group here. And all of this is not optional so for me it should be in TransformerVoltageControlOuterLoop.

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/TransformerRatioManager.java

annetill · 2024-06-11T14:02:55Z

I think this PR should be separated in two PRs:

If I understand well your code, the new parameter "stable" is only used by TransformerRatioManager. So if I understand well, it is just a parameter that proposes a different management of parallel transformers. If yes, this should be in a dedicated PR.
The rest of the code impacts the main behavior and should be in a dedicated PR. And as I mention in my review, I don't understand why we introduce the class GroupVoltageControlManager.

…r name and enable json serde Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

…open-loadflow into tap_update_algo

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…open-loadflow into tap_update_algo

geofjamg · 2024-06-20T10:45:52Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GeneratorVoltageControlManager.java

+        this.minNominalVoltageLimit = limitOverride < 0 ? calculateMaxControlledNominalVoltage(network) : limitOverride;
+    }
+
+    private static double calculateMaxControlledNominalVoltage(LfNetwork network) {


We should have a consistent name with the minNominalVoltageLimit and decide if it is a min or a max.

Done
-> computeDefaultMinNominalVoltageLimit

geofjamg · 2024-06-20T10:46:37Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GeneratorVoltageControlManager.java

+     * Disables the voltage control of generators if controlled bus nominal voltage is under the limit.
+     */
+    public void disableGeneratorVoltageControlsUnderMaxControlledNominalVoltage(LfNetwork network) {
+        for (LfBus bus : network.getControlledBuses(VoltageControl.Type.GENERATOR)) {


clear the disabledControllerBuses before ?

Done. I hesitated between a clear and an IllegalStateException if list not empty...
Opted for a clear with a comment in code that this use case of multiple calls was not the initial design intention and was not tested.

geofjamg · 2024-06-20T10:49:35Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/GeneratorVoltageControlManager.java

+        }
+    }
+
+    private boolean isBusBehindVeryHighVoltageTransfo(LfBus bus, double limit) {


=> isBusBehindStepupTransformer?
Indeed we can improve the check by

checking that the branch is a transformer steping up the voltage

multiple transformers starting from stator bus ?

src/main/java/com/powsybl/openloadflow/ac/outerloop/TransformerVoltageControlOuterLoop.java

geofjamg · 2024-06-20T11:06:01Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/tap/TransformerRatioManager.java

+        }
+    }
+
+    private final Map<String, Pair<Double, SharedControl>> sharedControlByBranchId = new HashMap<>();


Instead of using this Pair (not really readable) why not moving the r1 to SharedControl ? Just for using a record ?

Because as far as I understand a shared control is shared between the branches of a shared control, so the object is shared too.

Yes, right. So maybe we should have another class to embed the SharedControl and its r1 value

Pair is often considered as a poor design choice and should try to avoid it in OLF

It was a record initially. Doesn't change much. What we need is a multikey.

Indeed I removed it because the good naming was not so easy.

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…open-loadflow into tap_update_algo

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

…_algo

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

…open-loadflow into tap_update_algo

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

…open-loadflow into tap_update_algo

sonarqubecloud · 2024-07-02T08:51:55Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dismiss

Initial backport from investigation branch - before working on code c…

8619fd0

…overage of new code Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

vidaldid-rte requested review from geofjamg, jeandemanged, rosiereflo and annetill May 17, 2024 09:23

vidaldid-rte changed the title ~~[WIP] Improve taptuning in TransformerVoltageControlOuterLoop~~ [WIP] Improve tap tuning in TransformerVoltageControlOuterLoop May 17, 2024

vidaldid-rte added 6 commits May 17, 2024 15:40

add a test in stable mode

cbf33bb

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

add a test for tht limit

b4efbc0

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

remove a line to prevent checker style from striking

4d6e6a8

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

remove some sonar issues

1b69e97

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

test outofbound tap

c5ca6dc

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

another MAJOR problem to fix from style checker perspective.

e72da3b

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

vidaldid-rte force-pushed the tap_update_algo branch from 1342166 to e72da3b Compare May 17, 2024 14:49

vidaldid-rte added 7 commits May 17, 2024 17:10

troubleshoot test issue on server

74064e7

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

correct network copy to ensure voltage controlis active

26201d8

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

isolate test ith different results locally and on server for troubles…

ffe1725

…hooting Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

add a paranoid trace to troubleshoot build issue

e2d22de

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

black magic discovered ?

90fae0d

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

restore paranoic trace

40502c1

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

last try this week

26fe407

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

vidaldid-rte changed the title ~~[WIP] Improve tap tuning in TransformerVoltageControlOuterLoop~~ Improve tap tuning in TransformerVoltageControlOuterLoop May 17, 2024

Merge branch 'main' into tap_update_algo

08a5a27

jeandemanged previously requested changes May 28, 2024

View reviewed changes

annetill mentioned this pull request May 28, 2024

Fix transformer voltage control outer loop AFTER GENERATOR #1038

Merged

7 tasks

vidaldid-rte and others added 4 commits May 31, 2024 16:30

Add header and author on new files

cff1ea8

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Merge branch 'main' into tap_update_algo

0682ad2

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Remove a THT that escaped previous cleaning

350a48c

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Merge branch 'main' into tap_update_algo

3a89bdc

annetill reviewed Jun 11, 2024

View reviewed changes

vidaldid-rte and others added 4 commits June 12, 2024 10:56

rename parameter getter and setters to eactly match declared paramete…

84b22e7

…r name and enable json serde Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Merge branch 'tap_update_algo' of https://github.com/powsybl/powsybl-…

488517d

…open-loadflow into tap_update_algo

Clean TransformerRatioManager.

7da2a7c

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'tap_update_algo' of https://github.com/powsybl/powsybl-…

34c9548

…open-loadflow into tap_update_algo

annetill added the PR: next-release label Jun 19, 2024

Merge branch 'main' into tap_update_algo

fcf0605

geofjamg reviewed Jun 20, 2024

View reviewed changes

annetill and others added 7 commits June 20, 2024 18:35

Fix rewriting.

ce4897f

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'tap_update_algo' of https://github.com/powsybl/powsybl-…

d6d98e8

…open-loadflow into tap_update_algo

review remark on naming consistency

17f1034

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

protect class against unanticipated usages

9dcf651

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Fix parameter name.

a645092

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

code review - improve criteria to detect group behind VHV transformer(s)

650d436

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Fix parameter name.

61e8a83

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

vidaldid-rte force-pushed the tap_update_algo branch from 8a12f12 to 61e8a83 Compare June 21, 2024 12:45

annetill and others added 3 commits June 21, 2024 14:54

Merge remote-tracking branch 'origin/tap_update_algo' into tap_update…

4d200ce

…_algo

Add documentation + add load tap changing capabilities in criteria.

b5e623a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'main' into tap_update_algo

b3b28b7

annetill removed the PR: next-release label Jun 27, 2024

vidaldid-rte and others added 5 commits June 28, 2024 15:12

fix regression

ca2c7bf

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Merge branch 'tap_update_algo' of https://github.com/powsybl/powsybl-…

7b39f5b

…open-loadflow into tap_update_algo

Change method name.

5323f52

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

fix conflicts on parameters

a161dc6

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>

Merge branch 'tap_update_algo' of https://github.com/powsybl/powsybl-…

a0e4246

…open-loadflow into tap_update_algo

annetill changed the title ~~Improve tap tuning in TransformerVoltageControlOuterLoop~~ Improve transformer voltage control AFTER_GNERATOR_VOLTAGE_CONTROL Jul 2, 2024

annetill approved these changes Jul 2, 2024

View reviewed changes

annetill merged commit b4c0e21 into main Jul 2, 2024
7 checks passed

annetill deleted the tap_update_algo branch July 2, 2024 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve transformer voltage control `AFTER_GNERATOR_VOLTAGE_CONTROL` #1032

Improve transformer voltage control `AFTER_GNERATOR_VOLTAGE_CONTROL` #1032

vidaldid-rte commented May 17, 2024 •

edited by annetill

Loading

jeandemanged left a comment

annetill left a comment

annetill Jun 11, 2024

vidaldid-rte Jun 11, 2024

annetill Jun 11, 2024

annetill Jun 11, 2024

annetill Jun 11, 2024

annetill commented Jun 11, 2024

geofjamg Jun 20, 2024

vidaldid-rte Jun 21, 2024

geofjamg Jun 20, 2024

vidaldid-rte Jun 21, 2024

geofjamg Jun 20, 2024 •

edited

Loading

geofjamg Jun 20, 2024

annetill Jun 20, 2024

geofjamg Jun 20, 2024

geofjamg Jun 20, 2024

vidaldid-rte Jun 20, 2024

annetill Jun 20, 2024

sonarqubecloud bot commented Jul 2, 2024

Improve transformer voltage control AFTER_GNERATOR_VOLTAGE_CONTROL #1032

Improve transformer voltage control AFTER_GNERATOR_VOLTAGE_CONTROL #1032

Conversation

vidaldid-rte commented May 17, 2024 • edited by annetill Loading

jeandemanged left a comment

Choose a reason for hiding this comment

annetill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annetill commented Jun 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geofjamg Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 2, 2024

Quality Gate passed

Improve transformer voltage control `AFTER_GNERATOR_VOLTAGE_CONTROL` #1032

Improve transformer voltage control `AFTER_GNERATOR_VOLTAGE_CONTROL` #1032

vidaldid-rte commented May 17, 2024 •

edited by annetill

Loading

geofjamg Jun 20, 2024 •

edited

Loading