Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bus imbalance with slack distribution on load #1040

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented May 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Observed non-zero bus Q balance when a bus has:

  • a reactive only load (P0 = 0 MW, Q0 = X Mvar)
  • another 'normal' load (P0 = Y MW, Q0 = Z Mvar)

and slack distribution is on loads, with constant power factor.

What is the new behavior (if this is a feature change)?
Correct / zero bus Q balance

Does this PR introduce a breaking change or deprecate an API?

  • No

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged requested a review from caioluke June 3, 2024 08:08
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Copy link
Member

@caioluke caioluke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Copy link

sonarqubecloud bot commented Jun 3, 2024

@jeandemanged jeandemanged requested a review from caioluke June 3, 2024 09:05
@jeandemanged jeandemanged merged commit b5831dd into main Jun 4, 2024
6 checks passed
@jeandemanged jeandemanged deleted the fix-constant-power-factor-reactive-only-load branch June 4, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants