Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At most one flow/factor states calculation for one contingency in DC sensitivity analysis #1061

Merged
merged 18 commits into from
Jul 12, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Jul 8, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

What is the current behavior?

Multiple modified flow states calculations can be performed for a given contigency in DC sensitivity analysis, e.g. when the connectivity changed and a pst is lost. Same for factor states.

What is the new behavior (if this is a feature change)?
At most one flow/factor states calculation is performed for each contingency.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@p-arvy p-arvy requested review from annetill and Hadrien-Godard July 8, 2024 10:40
Base automatically changed from remove_optim_sensi_dc to main July 9, 2024 07:42
p-arvy added 12 commits July 9, 2024 14:41
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
This reverts commit 4f5fbe3.
@p-arvy p-arvy force-pushed the one-sensi-calculation-for-one-contingency branch from f65fda3 to d819cfb Compare July 9, 2024 14:41
p-arvy and others added 2 commits July 9, 2024 16:47
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Copy link

Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI powsybl-open-rao passed, internal integration tests are not passing (one only and not a dc computation...). So I feel confident by merging this PR.

@annetill annetill merged commit c23fda6 into main Jul 12, 2024
7 checks passed
@annetill annetill deleted the one-sensi-calculation-for-one-contingency branch July 12, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants