Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC loadflow: no network update on NO_CALCULATION #1075

Merged
merged 3 commits into from
Aug 9, 2024
Merged

AC loadflow: no network update on NO_CALCULATION #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8eacbd
Update unit test to check no update on NO_CALCULATION island
flo-dup Aug 7, 2024
ff7b8bb
Add the success check prior to component update
flo-dup Aug 7, 2024
eedacff
Fix to take into account alwaysUpdateNetwork parameter
flo-dup Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/powsybl/openloadflow/OpenLoadFlowProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ private void updateAcState(Network network, LoadFlowParameters parameters, OpenL
}
try {
// update network state
if (atLeastOneComponentHasToBeUpdated || parametersExt.isAlwaysUpdateNetwork()) {
if (atLeastOneComponentHasToBeUpdated && result.isSuccess()
|| parametersExt.isAlwaysUpdateNetwork()) {
Comment on lines +107 to +108
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention that alwaysUpdateNetwork parameter makes the network to be updated even on NO_CALCULATION components, but that should be the expected behaviour.

var updateParameters = new LfNetworkStateUpdateParameters(parameters.isUseReactiveLimits(),
parameters.isWriteSlackBus(),
parameters.isPhaseShifterRegulationOn(),
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ void testMultipleComponents() throws IOException {
assertEquals(LfNetwork.Validity.INVALID_NO_GENERATOR_VOLTAGE_CONTROL.toString(), result.getComponentResults().get(1).getStatusText());
assertEquals(LoadFlowResult.ComponentResult.Status.NO_CALCULATION, result.getComponentResults().get(2).getStatus());
assertEquals(LfNetwork.Validity.INVALID_NO_GENERATOR.toString(), result.getComponentResults().get(2).getStatusText());
assertEquals(Double.NaN, network.getLoad("d9").getTerminal().getP()); // load on the NO_CALCULATION island connected component
LoadFlowAssert.assertReportEquals("/multipleConnectedComponentsAcReport.txt", reportNode);

// test in DC
Expand All @@ -151,6 +152,7 @@ void testMultipleComponents() throws IOException {
assertEquals("Converged", result.getComponentResults().get(1).getStatusText());
assertEquals(LoadFlowResult.ComponentResult.Status.NO_CALCULATION, result.getComponentResults().get(2).getStatus());
assertEquals(LfNetwork.Validity.INVALID_NO_GENERATOR.toString(), result.getComponentResults().get(2).getStatusText());
assertEquals(Double.NaN, network.getLoad("d9").getTerminal().getP()); // load on the NO_CALCULATION island connected component
LoadFlowAssert.assertReportEquals("/multipleConnectedComponentsDcReport.txt", reportNode);
}

Expand Down