Fast restart for active power target change #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
geofjamg
commented
Sep 9, 2024
| @@ -335,6 +335,7 @@ private void applyGeneratorChange(LfNetworkParameters networkParameters) { | |||
| double newTargetP = generatorChange.isRelative() ? generator.getTargetP() + generatorChange.activePowerValue() : generatorChange.activePowerValue(); | |||
| generator.setTargetP(newTargetP); | |||
| generator.setInitialTargetP(newTargetP); | |||
| // FIXME should be use generator.reApplyActivePowerControlChecks() instead ? | |||
There was a problem hiding this comment.
@annetill if we do that we break some unit test ?
Do this behaviour on purpose to not being able to get back the generator to active power control after contingency if target is now correct ?
There was a problem hiding this comment.
It is an error of the code on main branch, your proposal is the right one and unit tests have to be fixed.
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
geofjamg
changed the title
|
annetill
reviewed
Sep 12, 2024
| @@ -156,6 +157,16 @@ private CacheUpdateResult onInjectionUpdate(Injection<?> injection, BiFunction<A | |||
| return CacheUpdateResult.elementNotFound(); | |||
| } | |||
|
|
|||
| private static CacheUpdateResult updateLfGeneratorTargetP(String id, double oldValue, double newValue, AcLoadFlowContext context, LfBus lfBus) { | |||
| double valueShift = newValue - oldValue; | |||
There was a problem hiding this comment.
Just a question: why do you need this temporary "valueShift" ?
annetill
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the new behavior (if this is a feature change)?
We are able to change target p of generators and batteries with fast restart
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: