Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] (OLD : see #1122 and #1123) DC Area Interchange Control Outer Loop #1099

Closed
wants to merge 17 commits into from

Conversation

vmouradian
Copy link
Member

@vmouradian vmouradian commented Oct 11, 2024

HAS BEEN SPLITTED INTO 2 PRs :

#1122
#1123

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

feature

What is the current behavior?

AIC not supported for DC Loadflow

What is the new behavior (if this is a feature change)?
AIC outerloop is supported for DC Loadflow

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
@vmouradian vmouradian self-assigned this Oct 11, 2024
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
jeandemanged and others added 2 commits November 12, 2024 17:07
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation to be updated.

This PR is a quite long, we might want to break it in multiple pieces:

  • DC outerloop refactoring
  • AreaInterchangeControl

Comment on lines -175 to 212
if (parameters.isDistributedSlack()) {
distributeSlack(network, network.getBuses(), parameters.getBalanceType(), parameters.getNetworkParameters().isUseActiveLimits());
double slackBusActivePowerMismatch = getActivePowerMismatch(network.getBuses());
double distributedActivePower = 0.0;
if (parameters.isDistributedSlack() || parameters.isAreaInterchangeControl()) {
distributedActivePower = distributeSlack(network, network.getBuses(), parameters.getBalanceType(), parameters.getNetworkParameters().isUseActiveLimits());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was like this before, but here we do not account for slack distribution failure behavior parameter.
Could be in another PR, in this case just add a // FIXME.
Important note: in the case of AIC, failing here may not be relevant. Here is done only global slack distribution. But we may have the case of distribution failure when distributing mismatch globally, and at the same time no failure when distributing per area later on in the outerloops.

@vmouradian vmouradian changed the title [WIP] DC Area Interchange Control Outer Loop [WIP] (OLD : see #1122 and #1123) DC Area Interchange Control Outer Loop Nov 18, 2024
@vidaldid-rte
Copy link
Collaborator

@jeandemanged @vmouradian shouldn't this one be closed now that it is split in 2 parts ?

@vmouradian
Copy link
Member Author

@jeandemanged @vmouradian shouldn't this one be closed now that it is split in 2 parts ?

Yes, I think we can close it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants