Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Knitro ac solver #1106

Closed
wants to merge 116 commits into from
Closed

[WIP] Knitro ac solver #1106

wants to merge 116 commits into from

Conversation

jeanneArchambault
Copy link
Contributor

@jeanneArchambault jeanneArchambault commented Oct 21, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

p-arvy and others added 30 commits April 22, 2024 15:09
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
default value + change value critère d'arrêt
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…ètre d'init dans le solveur Knitro

Le paramètre du solverKnitro qui décrit quel type d'initialisation est faite pour V et Theta a été passé en commentaire (et également dans le tests correspondants) car à priori inutile vu que ce n'est pas non plus un attribut de newton raphson
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
… paramètre stopping criteria + TU associés (modif de paramètre de convergence dans Knitro)

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…ltageNewtonRaphson

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
… other variables (then V and theta)

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…variables

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…n linear cts to callback function

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…constraints

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Copy link
Member

@jeandemanged jeandemanged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks promising, I need to grab a knitro license ;)

hs_err_pid13576.log Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/test/resources/logback-test.xml Show resolved Hide resolved
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
pom.xml Outdated Show resolved Hide resolved
…rameters)

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
…structure

Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
Signed-off-by: jarchambault <jeanne.archambault@artelys.com>
@jeandemanged
Copy link
Member

Closing: addressed by #1107 and powsybl/powsybl-open-loadflow-knitro-solver#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants