Retry LU decomposition if incremental mode fails #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidaldid-rte
changed the title
vidaldid-rte
force-pushed
the
hvdc_pmax_sparse_matrix
branch
4 times, most recently
from
25b94ea to
7bd5798
Compare
vidaldid-rte
changed the title
geofjamg
reviewed
Nov 7, 2024
src/test/java/com/powsybl/openloadflow/equations/LUDecompositionTest.java
Show resolved
Hide resolved
geofjamg
approved these changes
Nov 7, 2024
jeandemanged
approved these changes
Nov 13, 2024
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…update Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…ple apparently care about sonar stats of so called issues Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
force-pushed
the
hvdc_pmax_sparse_matrix
branch
from
70b1c48 to
cb7f556
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug Fix
What is the current behavior?
In some rare cases, the NR fails with a MatrixException - klu_refactor error KLU_SINGULAR
This happens when the Jacobian Matrix uptes the LU in incremental mode.
But, in those cases, if the LU matrix is updated in non incremental mode the operation succeeds.
At this time, this has only be seen in large model and it has not been possible to isolate a simple case with the issue.
What is the new behavior (if this is a feature change)?
When the Jacobian updates occurs in incremental mode, if the LU update fails a second try is attempted in non incremental mode.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: