Refactor DC Woodbury #1111
Refactor DC Woodbury #1111
Conversation
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
src/main/java/com/powsybl/openloadflow/sa/WoodburyDcSecurityAnalysis.java
Show resolved
Hide resolved
|
There are still type of contingenies in DcSensitivyAnalysis where a new DenseMatrix is created (For example in caculateFactorStates. This can lead to the same memory issues in cases where many contingency fall in such category. It would be good to have a resizableDenseMatrix that can grow its directBuffer if needed when resized, and could be used as a working matrix for all contingencies. But this is maybe out of the scope of this PR since it needs an evolution i core. |
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Yes, I agree with that, a "ResizableDenseMatrix" would help using less memory. But indeed may be out of this scope (and would need a modification in powsybl-core) |
| // create workingContingencyStates that will be a working copy of pre-contingency states | ||
| double[] workingContingencyStates = preContingencyStates.clone(); |
There was a problem hiding this comment.
Use System.arraycopy instead of clone ?
There was a problem hiding this comment.
Done ! I did not know about this subtle difference but seems slightly better indeed (https://stackoverflow.com/questions/7179251/is-there-any-reason-to-prefer-system-arraycopy-over-clone)
There was a problem hiding this comment.
That was true for Java5 in 2006 but if you run the bench today you see no difference after the JIT has comleted.
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
This PR follows this PR: #1109
Some variable names and comments have been modified to ensure a better maintanability of the code
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?