Fix injections ignored on slack buses when using multi slacks #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmouradian
force-pushed
the
bugfix/multi-slack-target-vector
branch
from
280c440 to
b12d471
Compare
vmouradian
force-pushed
the
bugfix/multi-slack-target-vector
branch
from
b12d471 to
0739fab
Compare
vmouradian
changed the title
jeandemanged
requested changes
Nov 8, 2024
src/test/java/com/powsybl/openloadflow/ac/MultipleSlackBusesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/MultipleSlackBusesTest.java
Outdated
Show resolved
Hide resolved
jeandemanged
changed the title
| // 0 = slack_p1 - slack_p3 | ||
| // example for 3 slack buses | ||
| // target_p2 = slack_p2 - slack_p1 + inj_p2 | ||
| // target_p3 = slack_p3 - slack_p1 + inj_p2 |
There was a problem hiding this comment.
Not sure about my remark but shouldn't we rather have :
// target_p2 = slack_p2 - slack_p1
// target_p3 = slack_p3 - slack_p1
There was a problem hiding this comment.
you are absolutely right ... thanks / fixed
SylvestreSakti
approved these changes
Nov 13, 2024
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
vidaldid-rte
force-pushed
the
bugfix/multi-slack-target-vector
branch
from
d44796f to
bb2947b
Compare
|
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When using multi slack, loads or gens on slack buses are ignored because value for P in target vector is 0. This results in the existing injections to be "mangled"/reported in the slack injection incorrectly.
What is the new behavior (if this is a feature change)?
Take P injection into account on slack buses equations for the multi slack case
Does this PR introduce a breaking change or deprecate an API?