Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DC load flow with modified target vector in WoodburyEngine #1126

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Nov 21, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

DC LF with modified target vector is moved in WoodburyEngine following dicussion in #1095.

What is the current behavior?

The method is in DcLoadFlowEngine.

What is the new behavior (if this is a feature change)?
The method is in WoodburyEngine.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
@vidaldid-rte vidaldid-rte force-pushed the move-run-with-modified-target-vector-in-woodbury branch from a3d55fb to 59011fb Compare November 26, 2024 11:02
@vidaldid-rte vidaldid-rte merged commit 91f81d0 into main Nov 26, 2024
7 checks passed
@vidaldid-rte vidaldid-rte deleted the move-run-with-modified-target-vector-in-woodbury branch November 26, 2024 11:46
vidaldid-rte pushed a commit that referenced this pull request Dec 11, 2024
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants