-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ViolationLocation to LimitViolationManager #1134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamal-khey <myjamal89@gmail.com>
0cd0482
to
d4fc0f8
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
d3ad199
to
5d58e60
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
EtienneLt
reviewed
Nov 28, 2024
src/main/java/com/powsybl/openloadflow/network/impl/LfBusImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sa/LimitViolationManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sa/LimitViolationManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…wsybl-open-loadflow into jamal-khey/nodesByBus
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
…wsybl-open-loadflow into jamal-khey/nodesByBus
vidaldid-rte
approved these changes
Nov 29, 2024
EtienneLt
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except for this possible refactory it is good for me
src/main/java/com/powsybl/openloadflow/network/impl/LfDanglingLineBus.java
Show resolved
Hide resolved
EtienneLt
approved these changes
Nov 29, 2024
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
SylvestreSakti
approved these changes
Dec 2, 2024
|
vidaldid-rte
added a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com> Co-authored-by: Didier Vidal <didier.vidal_externe@rte-france.com> Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #1133
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
This PR is a continuation of the powsybl-core violation location for open-load-flow. Follow the same migration steps as described in that pull request.