Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ViolationLocation to LimitViolationManager #1134

Merged
merged 17 commits into from
Dec 2, 2024

Conversation

jamal-khey
Copy link
Contributor

@jamal-khey jamal-khey commented Nov 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #1133

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
This PR is a continuation of the powsybl-core violation location for open-load-flow. Follow the same migration steps as described in that pull request.

@jamal-khey jamal-khey self-assigned this Nov 26, 2024
@jamal-khey jamal-khey changed the title add ViolationLocation to LimitViolationManager WIP: add ViolationLocation to LimitViolationManager Nov 26, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com>
@jamal-khey jamal-khey force-pushed the jamal-khey/nodesByBus branch from 0cd0482 to d4fc0f8 Compare November 26, 2024 17:35
@jamal-khey jamal-khey linked an issue Nov 26, 2024 that may be closed by this pull request
@jamal-khey jamal-khey force-pushed the jamal-khey/nodesByBus branch from d3ad199 to 5d58e60 Compare November 27, 2024 09:59
@jamal-khey jamal-khey changed the title WIP: add ViolationLocation to LimitViolationManager add ViolationLocation to LimitViolationManager Nov 27, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey and others added 10 commits November 28, 2024 15:04
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for this possible refactory it is good for me

Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
@vidaldid-rte vidaldid-rte merged commit 4a54ac0 into main Dec 2, 2024
7 checks passed
@vidaldid-rte vidaldid-rte deleted the jamal-khey/nodesByBus branch December 2, 2024 10:21
vidaldid-rte added a commit that referenced this pull request Dec 11, 2024
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Co-authored-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add the violation location in voltage LimitViolations
5 participants