Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes related to Woodbury in fast dc package #1145

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Dec 5, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

The classes related to Woodbury Engine are moved in com/powsybl/openloadflow/dc/fastdc package.

What is the current behavior?

The classes are in com/powsybl/openloadflow/sensi package.

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: p-arvy <pierre.arvy@artelys.com>
@p-arvy p-arvy requested a review from vidaldid-rte December 5, 2024 17:44
@p-arvy
Copy link
Member Author

p-arvy commented Dec 5, 2024

This PR should be merged before #1095.

@vidaldid-rte vidaldid-rte merged commit 4198f7a into main Dec 6, 2024
8 checks passed
@vidaldid-rte vidaldid-rte deleted the refactor-woodbury-classes-in-fast-dc branch December 6, 2024 10:48
vidaldid-rte pushed a commit that referenced this pull request Dec 11, 2024
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants