Handle slack distribution failure behavior in DC Load Flow #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
4 tasks
jeandemanged
force-pushed
the
dc_slack_distribution_failure_behavior_fail
branch
from
14665d2 to
36dc40a
Compare
jeandemanged
changed the base branch from
main
to
fix-active-power-distribution-reports
jeandemanged
force-pushed
the
dc_slack_distribution_failure_behavior_fail
branch
from
6bb3947 to
36d804d
Compare
…lowResult Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: PRABAKARAN Sylvestre <sylvestre.prabakaran@rte-france.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
jeandemanged
force-pushed
the
dc_slack_distribution_failure_behavior_fail
branch
from
36d804d to
30b29e8
Compare
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Base automatically changed from
fix-active-power-distribution-reports
to
main
December 12, 2024 12:13
…avior_fail # Conflicts: # src/main/java/com/powsybl/openloadflow/ac/outerloop/DistributedSlackOuterLoop.java # src/main/java/com/powsybl/openloadflow/network/util/ActivePowerDistribution.java
jeandemanged
force-pushed
the
dc_slack_distribution_failure_behavior_fail
branch
from
9dec4c9 to
5331ad0
Compare
jeandemanged
changed the title
SylvestreSakti
commented
Dec 12, 2024
| distributedActivePower = distributeSlack(network, network.getBuses(), parameters.getBalanceType(), parameters.getNetworkParameters().isUseActiveLimits()); | ||
| LoadFlowParameters.BalanceType balanceType = parameters.getBalanceType(); | ||
| boolean useActiveLimits = parameters.getNetworkParameters().isUseActiveLimits(); | ||
| ActivePowerDistribution activePowerDistribution = ActivePowerDistribution.create(balanceType, false, useActiveLimits); |
There was a problem hiding this comment.
Can't we use the distributeSlack() method to avoid duplication ? The output of distributeSlack() is not used anywhere else (in WoodburyEngine the method is called without using its output) so it can be changed to return the result variable
There was a problem hiding this comment.
I inlined it to avoid a double-call to getActivePowerMismatch, indeed we should perhaps move distributeSlack() to Woodbury, and create an issue about usage of slack distribution failure behavior in Woodbury engine
| } | ||
|
|
||
| @Test | ||
| void testSlackDistributionDisabledResults() { |
There was a problem hiding this comment.
Can be done with a @ParameterizedTest ?
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
vidaldid-rte
approved these changes
Dec 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
The parameter
slackDistributionFailureBehavioris now taken into account in DC load flow mode which wasn't the case.What is the current behavior?
No use of the parameter
slackDistributionFailureBehaviorfor DC load flowWhat is the new behavior (if this is a feature change)?
Using the parameter
slackDistributionFailureBehaviorfor DC load flowDoes this PR introduce a breaking change or deprecate an API?