Refacto lhs #1147
Merged
Refacto lhs #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
force-pushed
the
refacto_lhs
branch
from
f5b28dc to
90500d6
Compare
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
force-pushed
the
refacto_lhs
branch
from
59f0008 to
f80af7a
Compare
7 tasks
vidaldid-rte
force-pushed
the
refacto_lhs
branch
from
f80af7a to
f150475
Compare
| default double eval(StateVector sv) { | ||
| throw new UnsupportedOperationException("Not implemented"); | ||
| default double evalLhs() { | ||
| return eval() + (hasRhs() ? rhs() : 0); |
There was a problem hiding this comment.
Should it be - rhs instead of + rhs ?
Suggested change
| return eval() + (hasRhs() ? rhs() : 0); | |
| return eval() - (hasRhs() ? rhs() : 0); |
There was a problem hiding this comment.
You are right. Done.
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
vidaldid-rte
force-pushed
the
refacto_lhs
branch
from
1bbed47 to
87447f9
Compare
|
vidaldid-rte
merged commit 93bad2d
into
bugfix/pst-non-impedant-branch-bus-imbalance
8 checks passed
vidaldid-rte
added a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Didier Vidal <didier.vidal_externe@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
This is another approach to fix #1137
What kind of change does this PR introduce?
Clairify the equation model:
and
eval = evallhs - rhs
evallhs is used to solve equations
eval is used to get the equation or term quantity
What is the current behavior?
Errors seen with non impedant branches in DC near a PST or an HVDC in AC emulation with P0 non null.
Potental inconsitenscies each time a non null RHS is used
What is the new behavior (if this is a feature change)?
Error fixed
Does this PR introduce a breaking change or deprecate an API?