Voltage control of transformer: remote and local #127

annetill · 2020-07-06T07:24:52Z

Signed-off-by: Anne Tilloy anne.tilloy@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

#106

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

annetill · 2020-07-06T11:30:50Z

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerControlTest.java

+                .setTargetV(34.0);
+
+        LoadFlowResult result = loadFlowRunner.run(network, parameters);
+        // assertTrue(result.isOk()); FIXME


@geofjamg it is just a first version of voltage control by transformer and it is not working. At this test, the norm of my cost function is NaN. Do you have any idea of the problem ?

This is because the way tap changer voltage target equation is defined in AcEquationSystem.createBranchVoltageTargetEquation.
You should define a new equation type for tap changer target voltage (like BUS_TRANSFO_V)) because if you look at Equation.initTargets for type BUS_V, we look for a generator target voltage and not a tap changer target voltage so result is nan and this nan is added to targets vector before first NR.

geofjamg · 2020-07-06T12:59:47Z

src/main/java/com/powsybl/openloadflow/ac/outerloop/TransformerVoltageControlOuterLoop.java

+    }
+
+    @Override
+    public OuterLoopStatus check(OuterLoopContext context) {


I don't known if it is clear for you what has to be done here but here is a raw extract (to translate) of what is done in H2:

Articulation des 3 load flows pour la simulations des regleurs en charges

Pour rappel:

-LF1 = gpesTHT PV, grpes HT PV, regleurs fixes

-LF2 = gpesTHT PV, grpes HT PQ, regleurs variables

-LF3 = gpesTHT PV, grpes HT PV, regleurs fixes (apres discretisation)

I am not sure that we have to follow these 3 steps here. I think that I am going to follow simply what we have done for phase tap changer. It will be easy after that to make a more business and complex outerloop. In the EMF specifications, it is just written:
When calculating the steady state solution, a full Newton Raphson power flow algorithm is to be used, using the following settings:
• Q limits shall be respected (also for slack node/swing bus)
• Transformer tap adjustment is set to enabled
• Switched shunt adjustment is set to enabled
Transformer tap and switch shunt control is used during power flow calculation to enable regulating control during contingency analysis (where the solved system state is used for the base case). In case of non-convergence, switched shunt and transformer tap regulation is disabled and power flow calculation is started again.

Even if not specified you need to follow these 3 steps in order to emulate a realistics tap changer and generation co ntrol behaviour.

Do we have a way to have a generic outerloop that can be customized easily to simulate real world ?

Yes just one outerloop and a different behaviour at iteration 0, 1 and 2

annetill · 2020-07-08T12:23:46Z

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerControlTest.java

+
+        LoadFlowResult result = loadFlowRunner.run(network, parameters);
+        assertTrue(result.isOk());
+        assertVoltageEquals(34.433, bus3);


@geofjamg I have a small difference but I am not sure to understand why...

Because we round the r1?

There is something missing in the algo, maybe after rounding and fixing ratio it is to generation behind transformers du help reaching the target voltage?

sonarqubecloud · 2020-07-08T14:46:13Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
5 Code Smells

88.5% Coverage
0.0% Duplication

annetill · 2020-07-08T14:49:26Z

@geofjamg I have finished my first version. Can you make a review in order to be technically good ? It could be a good starting point for a functional definition of the transformer voltage control outerloop with our colleagues.

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…ybl/powsybl-open-loadflow into transformer-voltage-control

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2020-11-13T16:43:14Z

src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowTransformerControlTest.java

@@ -92,7 +92,7 @@ void voltageControlT2wtTest() {
        LoadFlowResult result = loadFlowRunner.run(network, parameters);
        assertTrue(result.isOk());
        assertVoltageEquals(134.281, bus2);
-        assertVoltageEquals(34.433, t2wt.getTerminal2().getBusView().getBus());
+        assertVoltageEquals(34.433, t2wt.getTerminal2().getBusView().getBus()); //FIXME: should be 34.427


@geofjamg here the FIXME: result is strange.

Remove unit case. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…ybl/powsybl-open-loadflow into transformer-voltage-control

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Remove useless functions for PiModel. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

flo-dup · 2020-11-23T11:01:53Z

src/main/java/com/powsybl/openloadflow/equations/EquationType.java

@@ -18,7 +18,8 @@
    BRANCH_I("i", SubjectType.BRANCH),
    ZERO_Q("z_q", SubjectType.BUS),
    ZERO_V("z_v", SubjectType.BRANCH),
-    ZERO_PHI("z_\u03C6", SubjectType.BRANCH);
+    ZERO_PHI("z_\u03C6", SubjectType.BRANCH),
+    ZERO_RHO1("z_\u03B1", SubjectType.BRANCH);


\u03C1 for rho

flo-dup · 2020-11-23T11:02:49Z

src/main/java/com/powsybl/openloadflow/equations/VariableType.java

@@ -13,6 +13,7 @@
    BUS_V("v"),
    BUS_PHI("\u03C6"),
    BRANCH_ALPHA1("\u03B1" + "1"),
+    BRANCH_RHO1("rho" + "1"),


\u03C1 instead of rho

flo-dup · 2020-11-23T11:06:47Z

src/main/java/com/powsybl/openloadflow/ac/equations/AcEquationSystem.java

+        if (bus.isDiscreteVoltageControlled()) {
+            equationSystem.createEquation(bus.getNum(), EquationType.BUS_V).addTerm(new BusVoltageEquationTerm(bus, variableSet));
+        }
+        if (bus.isDiscreteVoltageControlled() && bus.getDiscreteVoltageControl().getControllers().size() > 1) {


you could insert that if in the if above. Or we could add a isDiscreteVoltageSharedControlled method?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg · 2020-11-26T13:04:44Z

src/main/java/com/powsybl/openloadflow/equations/Equation.java

+    private static double getRho1DistributionTarget(LfNetwork network, int num, DistributionData data) {
+        LfBranch controllerBranch = network.getBranch(num);
+        LfBranch firstControllerBranch = network.getBranch(data.getFirstControllerElementNum());
+        return controllerBranch.getPiModel().getR1() - firstControllerBranch.getPiModel().getR1();


As far as I understand we keep the gap between rhos constant during regulation?
Maybe just add a comment somewhere?

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

sonarqubecloud · 2020-11-26T13:35:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

90.9% Coverage
0.0% Duplication

annetill commented Jul 6, 2020

View reviewed changes

geofjamg reviewed Jul 6, 2020

View reviewed changes

annetill commented Jul 8, 2020

View reviewed changes

annetill requested a review from geofjamg July 8, 2020 14:47

tadam50 and others added 24 commits September 18, 2020 10:46

Draft: Add phase control test on ThreeWindingsTransformer

7560b6a

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: make new tests passed

48dadc1

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: put all tests into AcLoadFlowPhaseShifterTest

1cbd4e8

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Clearing.

1b37bea

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Draft: Add phase-control on LegBranch

9ff37bb

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: fix findTapPosition parameter

b00fe79

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: fix test name

1caa3d4

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: add Branch Controller/Controlled on LfLegBranch

9a0363c

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft.

9ec98f3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Draft: fix checkstyle & use Optional instead of null object

b6c7227

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: add TwoWindingsTransformer controller / controlled link

aa9d6f1

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Fix remote regulation.

b8905ae

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Draft: refactoring + reduce code duplication

9cff711

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: fix sonar code smells

5d40840

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Draft: fix sonar bugs (not working with paralel runs)

f1cd899

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

First import of voltage control for twt.

44a3b28

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix branch implementation.

08d8c39

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

R1 as a variable of the equation system.

08d063e

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

First version of transformer voltage control.

1e7c137

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

New equation type.

7fe690e

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix per-unit.

c1af8fd

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

First simple version of the outerloop.

76a8c12

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix the function that rounded r1.

e344bf9

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Delete class from outerloop package.

dcf5f85

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill and others added 6 commits November 12, 2020 17:06

Merge branch 'master' into transformer-voltage-control

0133003

Improve remote test cases.

d1aa98a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Throw exception if a branch has a rtc and a ptc both regulating.

bf5603b

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'transformer-voltage-control' of https://github.com/pows…

091f254

…ybl/powsybl-open-loadflow into transformer-voltage-control

Apply review comments.

0a4a728

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Throw exception if a bus is controlled by generators and transformer.

8a392d3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill commented Nov 13, 2020

View reviewed changes

annetill requested review from geofjamg and flo-dup November 13, 2020 16:45

annetill and others added 9 commits November 13, 2020 17:56

Merge branch 'master' into transformer-voltage-control

38a5996

Test on real case.

079a399

Remove unit case. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'transformer-voltage-control' of https://github.com/pows…

9933027

…ybl/powsybl-open-loadflow into transformer-voltage-control

First import of voltage control shared by transformers.

5b0461a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add unit test.

10f9331

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix unit test.

e1f869b

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix in network loader.

3810716

Remove useless functions for PiModel. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix code smell.

33cff12

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Small refactoring.

7576398

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

flo-dup requested changes Nov 23, 2020

View reviewed changes

Small fixes after review.

65821d0

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

flo-dup approved these changes Nov 23, 2020

View reviewed changes

annetill and others added 3 commits November 26, 2020 11:49

Merge branch 'master' into transformer-voltage-control

874f9bb

Improve exception message.

e54c8e5

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Cleanup

85826c0

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg reviewed Nov 26, 2020

View reviewed changes

Change log levels

2ba455e

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg approved these changes Nov 26, 2020

View reviewed changes

geofjamg merged commit 4ff88b8 into master Nov 26, 2020

geofjamg deleted the transformer-voltage-control branch November 26, 2020 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voltage control of transformer: remote and local #127

Voltage control of transformer: remote and local #127

annetill commented Jul 6, 2020

annetill Jul 6, 2020

geofjamg Jul 6, 2020

geofjamg Jul 6, 2020

annetill Jul 8, 2020

geofjamg Jul 8, 2020

annetill Jul 8, 2020 •

edited

Loading

geofjamg Jul 8, 2020

annetill Jul 8, 2020

geofjamg Jul 8, 2020

geofjamg Jul 8, 2020

sonarqubecloud bot commented Jul 8, 2020

annetill commented Jul 8, 2020

annetill Nov 13, 2020

flo-dup Nov 23, 2020

flo-dup Nov 23, 2020

flo-dup Nov 23, 2020

geofjamg Nov 26, 2020

sonarqubecloud bot commented Nov 26, 2020

Voltage control of transformer: remote and local #127

Voltage control of transformer: remote and local #127

Conversation

annetill commented Jul 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annetill Jul 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jul 8, 2020

annetill commented Jul 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 26, 2020

annetill Jul 8, 2020 •

edited

Loading