Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack distribution on conform loads #144

Merged
merged 26 commits into from
Sep 11, 2020
Merged

Slack distribution on conform loads #144

merged 26 commits into from
Sep 11, 2020

Conversation

jeanChristopheGuillotin
Copy link
Contributor

@jeanChristopheGuillotin jeanChristopheGuillotin commented Sep 3, 2020 •
edited
Loading

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

annetill
annetill requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@annetill annetill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must change the class LfAbstractBus and build a unit test to improve this dev

src/main/java/com/powsybl/openloadflow/ac/DistributedSlackOnLoadOuterLoop.java Outdated
double fixedActivePowed = bus.getFixedActivePower();
double variableActivePower = bus.getVariableActivePower();

double newVariableActivePower = variableActivePower - remainingMismatch * factor;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must change the way the factors are computed.

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java Outdated Show resolved Hide resolved
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java Outdated Show resolved Hide resolved
jeanChristopheGuillotin and others added 13 commits September 3, 2020 17:01
@jeanChristopheGuillotin
change return by variable
b22d119
@geofjamg @jeanChristopheGuillotin
Index equations by subject (#141)
8f9360f 
* Index equations by subject
* Add unit tests

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
issue 110 mise en place des variables
815e3f2 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
correct checkstyle
eca8273 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
change return by variable
4f31e6f 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@annetill @jeanChristopheGuillotin
- p and q are set to side 1 of the branch. (#143)
9e8db24 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@geofjamg @jeanChristopheGuillotin
Refactoring, add LfNetworkParameters (#145)
7a02912 
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@geofjamg @jeanChristopheGuillotin
Equation term activation (#146)
adaa7de 
* Equation term activation/deactivation
* Add unit test
* Equation terms indexing is optional

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@flo-dup @jeanChristopheGuillotin
Connectivity calculations for security analysis (#149)
ad574ef 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
add test unitaire
8ee8d6e 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
change factor calcul
0bfc81b 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
add change with loadDetail
2b7c258 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
remove change on factor
584ffb5 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@jeanChristopheGuillotin
modified load
e7e9c86
@annetill
Merge.
b119739 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Merge branch 'master' into DRAFT]dev-issue110-JCG
74264e6
@annetill
Merge.
a7f8773 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@jeanChristopheGuillotin
modified loadDetail recuperation
d0e6fe8 
Signed-off-by: Jean-Christophe GUILLOTIN <jean-christophe.guillotin@rte-france.com>
@annetill
Copy link
Member

annetill commented Sep 9, 2020 •
edited
Loading

I will review as soon as possible. Can you see with Marco for the next issue that consists in keeping the power factor constant ? Thanks ! You can start from master branch, we will merge this PR later after review process.
And do not forget to sign off your commit with your first name, last name and address !

@annetill annetill changed the title issue 110 mise en place des variables Slack distribution on conform loads Sep 9, 2020
@annetill
Fixes.
18bf67b 
Introduce ratio variable part on fixed part for load active power.

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested review from geofjamg and flo-dup September 9, 2020 19:44
@annetill
Sonar cloud bug fix.
3c16586 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Modifications after review.
32058a5 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
flo-dup
flo-dup approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the benefit to use the per unit here, but it seems that it's the usual practice?

@annetill
Remove unuseful setter.
967354c 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Add new balance type parameter.
ce7061a 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 108e10e into master Sep 11, 2020
@annetill annetill deleted the DRAFT]dev-issue110-JCG branch September 11, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill requested changes

@flo-dup flo-dup flo-dup approved these changes

@geofjamg geofjamg Awaiting requested review from geofjamg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeanChristopheGuillotin @annetill @flo-dup @geofjamg