Open loadflow parameters management #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadam50
reviewed
Sep 9, 2020
| @@ -0,0 +1,62 @@ | |||
| /** | |||
| * Copyright (c) 2019, RTE (http://www.rte-france.com) | |||
|
|
||
| platformConfig.getOptionalModuleConfig("open-loadflow-default-parameters") | ||
| .ifPresent(config -> { | ||
| parameters.setBalanceType(config.getEnumProperty("balanceType", BalanceType.class, BalanceType.PROPORTIONAL_TO_GENERATION_P_MAX)); |
There was a problem hiding this comment.
Maybe we could add a new class util/ParameterConstants.java in order to group all parameter name as :
balanceType, dc, distributedSlack, ...
| parameters.setDc(config.getBooleanProperty("dc", false)); | ||
| parameters.setDistributedSlack(config.getBooleanProperty("distributedSlack", true)); | ||
| parameters.setLowImpedanceBranchMode(config.getEnumProperty("lowImpedanceBranchMode", LowImpedanceBranchMode.class, LowImpedanceBranchMode.REPLACE_BY_ZERO_IMPEDANCE_LINE)); | ||
| // p arameters.setSlackBusSelector() |
jlabous
force-pushed
the
Open_loadflow_parameters_management
branch
3 times, most recently
from
4588598 to
d8b71fe
Compare
flo-dup
requested changes
Sep 14, 2020
Comment on lines
+60
to
+62
| assertEquals(OpenLoadFlowParameters.BalanceType.PROPORTIONAL_TO_LOAD, olfParameters.getBalanceType()); | ||
| assertTrue(olfParameters.isDc()); |
There was a problem hiding this comment.
Add test for the 4 other parameters
src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java
Outdated
Show resolved
Hide resolved
flo-dup
approved these changes
Sep 15, 2020
Comment on lines
+135
to
+143
| parameters.setBalanceType(config.getEnumProperty(BALANCE_TYPE_PARAM_NAME, BalanceType.class, BALANCE_TYPE_DEFAULT_VALUE)); | ||
| parameters.setDc(config.getBooleanProperty(DC_PARAM_NAME, DC_DEFAULT_VALUE)); | ||
| parameters.setDistributedSlack(config.getBooleanProperty(DISTRIBUTED_SLACK_PARAM_NAME, DISTRIBUTED_SLACK_DEFAULT_VALUE)); | ||
| parameters.setLowImpedanceBranchMode(config.getEnumProperty(LOW_IMPEDANCE_BRANCH_MODE_PARAM_NAME, LowImpedanceBranchMode.class, LOW_IMPEDANCE_BRANCH_MODE_DEFAULT_VALUE)); | ||
| parameters.setVoltageRemoteControl(config.getBooleanProperty(VOLTAGE_REMOTE_CONTROLE_PARAM_NAME, VOLTAGE_REMOTE_CONTROLE_DEFAULT_VALUE)); | ||
| parameters.setThrowsExceptionInCaseOfSlackDistributionFailure( | ||
| config.getBooleanProperty(THROWS_EXCEPTION_IN_CASE_OF_SLACK_DISTRIBUTION_FAILURE_PARAM_NAME, THROWS_EXCEPTION_IN_CASE_OF_SLACK_DISTRIBUTION_FAILURE_DEFAULT_VALUE) | ||
| ); |
There was a problem hiding this comment.
I'm wondering why thoses lines are considered uncovered by the test, any ideas what we're missing?
There was a problem hiding this comment.
It might be possible that sonar could not trace the cal that go througth configLoader in an other package
annetill
reviewed
Sep 15, 2020
|
|
||
| private BalanceType balanceType = BalanceType.PROPORTIONAL_TO_GENERATION_P_MAX; // Default slack distribution on generators. | ||
| private LowImpedanceBranchMode lowImpedanceBranchMode = LOW_IMPEDANCE_BRANCH_MODE_DEFAULT_VALUE; | ||
|
|
||
| public enum BalanceType { | ||
| PROPORTIONAL_TO_GENERATION_P, // Not implemented yet. | ||
| PROPORTIONAL_TO_GENERATION_P_MAX, | ||
| PROPORTIONAL_TO_LOAD, |
There was a problem hiding this comment.
Can you add PROPORTIONAL_TO_CONFORM_LOAD ?
There was a problem hiding this comment.
Rebase on master done
There was a problem hiding this comment.
It is implemented indeed, see in the master branch. The issue is partly implemented.
annetill
changed the title
Signed-off-by: Jérémy LABOUS <jlabous@silicom.fr>
Signed-off-by: Jérémy LABOUS <jlabous@silicom.fr>
Signed-off-by: Jérémy LABOUS <jlabous@silicom.fr>
jlabous
force-pushed
the
Open_loadflow_parameters_management
branch
from
3db9008 to
891b010
Compare
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jérémy LABOUS jlabous@silicom.fr
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#147