Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase control corrections #166

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Phase control corrections #166

merged 3 commits into from
Oct 28, 2020

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Oct 27, 2020

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Phase regulation done when updating state even if not enabled in LoadFlowParameter

What is the new behavior (if this is a feature change)?
Phase regulation done only if enabled

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from annetill October 27, 2020 16:30
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

93.9% 93.9% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit def2fca into master Oct 28, 2020
@annetill annetill deleted the phase-control-corrections branch October 28, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants