Discard phase control if controlled branch is null or open #177
Conversation
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
| LOGGER.warn("Phase controlled branch {} is null: no phase control created", controlledBranchId); | ||
| return; | ||
| } | ||
| if (controlledBranch.getBus1() == null || controlledBranch.getBus2() == null) { |
There was a problem hiding this comment.
Is this check really useful? It seems equivalent to the one at line 265 ptc.getRegulationTerminal().getBusView().getBus() == null. In the tests at least there's no counterexample. Thus we never go through the line 266 anymore in the tests.
There was a problem hiding this comment.
The controlled branch could be open at one side: it could be the side of the regulating terminal or the other one.
There was a problem hiding this comment.
Ok. But then we should remove the test of line 265 which is useless. And it would be maybe better to add such a test of a null branch on the other side? Indeed if I comment out the lines 256-259 all tests stay passed, which shows that when it's null it's always on the regulating side.
Signed-off-by: Anne Tilloy anne.tilloy@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo check is done.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Two checks have been added and in case of null controlled branch or open controlled branch, the phase control is not created.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)