Slack distribution support for DC power flow #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
reviewed
Dec 9, 2020
| private void distributeSlack(LfNetwork network) { | ||
| double mismatch = network.getActivePowerMismatch(); | ||
| ActivePowerDistribution activePowerDistribution = ActivePowerDistribution.create(parameters.getBalanceType(), false); | ||
| activePowerDistribution.run(network, -mismatch); |
There was a problem hiding this comment.
Maybe we shoud invert the sign of Network.getActivePowerMismatch to avoid this minus anf be consistent everywhere?
There was a problem hiding this comment.
I have changed the sign. Do you think that I need to perform a functional validation ?
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restSlack distribution was not supported before for DC power flow. The slack was entirely put at the slack node.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Slack distribution is now supported for balance type PROPORTIONAL_TO_LOAD, PROPORTIONAL_TO_P_MAX and PROPORTIONAL_TO_CONFORM_LOAD. The power factor of loads is ignored as we are in a DC approximation. Looses are neglected. I need to add unit tests. A refactoring is needed for pre-distribution of slack used here and in the security analysis.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)