Add systematic analysis with contingencies to sensitivity analysis #189

Djazouli · 2020-12-17T11:50:55Z

Signed-off-by: Gael Macherel gael.macherel@artelys.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

#186

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

…ted to slack Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

...ain/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis/DcSlowContingencyAnalysis.java

...ain/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis/DcFastContingencyAnalysis.java

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…owsybl-open-loadflow into systematic_sensitivity

annetill · 2020-12-22T12:04:06Z

src/main/java/com/powsybl/openloadflow/sensi/AbstractDcSensitivityAnalysis.java

+                Injection<?> injection = getInjection(network, injectionFactor.getVariable().getInjectionId(), throwExceptionIfNullInjection());
+                if (injection == null) {
+                    LOGGER.debug("Injection {} not found in the network", injectionFactor.getVariable().getInjectionId());
+                    // FIXME


I have added here a FIXME because after the code review I think that we need a decidate analysis of contingencies, factors and injections to avoid treatements all over the code. This analysis will be done before the base case sensitivity analysis and before each N-k analysis. This graph analysis is needed because :

We only support sensivity analysis on main connected component but the external API exposes the whole network. The list of contingencies provided by the external API is also over the whole network and these lead to a lot of if/else in the code ;

We will need this kind of analysis on factors and injections involved in the slack distribution when a N-k leads to a separate connected component (connected or off load).

…om scratch Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

…owsybl-open-loadflow into systematic_sensitivity Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

src/main/java/com/powsybl/openloadflow/sensi/DcSlowSensitivityAnalysis.java

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

annetill · 2021-01-08T08:35:16Z

src/test/resources/logback-test.xml

@@ -16,7 +16,7 @@
    <root level="info">
        <appender-ref ref="STDOUT" />
    </root>
-    <logger name="com.powsybl.openloadflow" level="DEBUG" additivity="false">


I am going to revert that change, it is a mistake from myself.

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

annetill · 2021-01-08T08:44:48Z

src/main/java/com/powsybl/openloadflow/sensi/AbstractDcSensitivityAnalysis.java

+        }
+    }
+
+    static class SensitivityFactorWrapped {


LfSensitivityFactor is maybe a better name choice.

src/main/java/com/powsybl/openloadflow/sensi/AbstractDcSensitivityAnalysis.java

annetill · 2021-01-08T08:56:12Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

        }

-        // initialize right hand side
-        DenseMatrix rhs = initRhs(lfNetwork, equationSystem, factorsByVarConfig);
+        // Compute the partipation for every factor


Improve comment: "// Compute the participation to slack distribution for every factor". I can make some improvements in a dedicated commit if you agree, it will be easier.

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

annetill · 2021-01-08T09:07:01Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

+                // compute the participation for each injection factor (+1 on the injection, and then -participation on all
+                // elements participating to load balancing, that are still in the connected component of the factor's variable)
+                Function<String, Map<String, Double>> getParticipationForBus = busId -> participationPerCc.get(connectivity.getConnectivity().getComponentNumber(lfNetwork.getBusById(busId)));
+                computeFactorsInjection(getParticipationForBus, factorsGroups);


Maybe rename it with participationPerBus as earlier in the code.

annetill · 2021-01-08T09:12:10Z

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

+        List<SensitivityValue> sensitivityValues = calculateSensitivityValues(factorsGroups,
+                states, Collections.emptyList());
+
+        Collection<Contingency> straightforwardContingencies = new LinkedList<>();


straightforwardContingencies should be renamed to reflect that these contingencies do not loose connectivity. Maybe the opposite of losingConnectivityContingency . It would be more readable I think.

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

geofjamg · 2021-01-11T10:23:41Z

src/test/java/com/powsybl/openloadflow/network/ConnectedComponentNetworkFactory.java

@@ -0,0 +1,196 @@
+package com.powsybl.openloadflow.network;


License header

geofjamg · 2021-01-11T10:23:49Z

src/test/java/com/powsybl/openloadflow/network/ConnectedComponentNetworkFactory.java

+import com.powsybl.iidm.network.Network;
+import com.powsybl.iidm.network.TwoWindingsTransformer;
+
+public class ConnectedComponentNetworkFactory extends AbstractLoadFlowNetworkFactory {


Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

…tematic_sensitivity

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…owsybl-open-loadflow into systematic_sensitivity

sonarqubecloud · 2021-01-11T15:05:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
20 Code Smells

93.2% Coverage
0.0% Duplication

Djazouli added 4 commits December 17, 2020 12:46

first commit

061132c

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

add test on multiple elements, and add test when removing line connec…

eaa7060

…ted to slack Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

add first refactor in sensititivy analysis

137bbb4

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

use slow sensitivity analysis if the connectivity is broken

dca9b8a

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

geofjamg reviewed Dec 21, 2020

View reviewed changes

Djazouli and others added 4 commits December 22, 2020 09:21

move and rename files

76e2284

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Remove slack bus special management.

2697dbf

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Remove package.

2df93cd

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Manage contingency on open branches.

2f07fa0

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill self-requested a review December 22, 2020 11:47

annetill and others added 3 commits December 22, 2020 12:50

Rename before merge?

ae4bf8c

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'systematic_sensitivity' of https://github.com/powsybl/p…

7c8063e

…owsybl-open-loadflow into systematic_sensitivity

Merge branch 'master' into systematic_sensitivity

103438b

annetill reviewed Dec 22, 2020

View reviewed changes

Djazouli and others added 9 commits December 22, 2020 14:48

refactor slow sensitivity analysis to avoid reimporting everything fr…

b88059d

…om scratch Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Merge branch 'systematic_sensitivity' of https://github.com/powsybl/p…

15aebbe

…owsybl-open-loadflow into systematic_sensitivity Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

manage single loss of connectivity in fast analysis

cec47d0

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

add a check before basecase sensitivity analysis

d45ef66

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Merge branch 'master' into systematic_sensitivity

ab34798

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

merge fix

3142eec

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

add test where you loose several connected components at the same time

86fe5dd

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Renaming and rewording.

831d789

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge.

757a441

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill reviewed Dec 24, 2020

View reviewed changes

src/main/java/com/powsybl/openloadflow/sensi/DcSlowSensitivityAnalysis.java Outdated Show resolved Hide resolved

annetill requested a review from geofjamg December 24, 2020 12:54

Djazouli added 5 commits December 24, 2020 14:45

fix load distribution in test

f97e21d

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

adding some tests

c94af10

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

fix slow sensitivity analysis

57f3380

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

remove contingencies from security analysis

eb80e72

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

remove some code smells

bf6abad

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

remove some unefficient map calls for perfs

4b6ca29

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

annetill reviewed Jan 8, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java Outdated Show resolved Hide resolved

annetill reviewed Jan 8, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java Outdated Show resolved Hide resolved

annetill reviewed Jan 8, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/sensi/AbstractDcSensitivityAnalysis.java Outdated Show resolved Hide resolved

annetill reviewed Jan 8, 2021

View reviewed changes

remove abstractdcsensitivityanalysis

f75f556

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

annetill reviewed Jan 8, 2021

View reviewed changes

Djazouli and others added 6 commits January 8, 2021 10:50

cache injections bus for factors to improve perfs

fd2400b

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

move sensitivities and contingencies in different matrix

51f30b6

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

remove a code smell

9e8e24c

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Close LU decomposition

b730ce6

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

remove unused function

2e98253

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>

Merge branch 'master' into systematic_sensitivity

0a65d32

annetill marked this pull request as ready for review January 11, 2021 08:29

geofjamg requested changes Jan 11, 2021

View reviewed changes

geofjamg and others added 4 commits January 11, 2021 13:27

Fic copyright and author

8459e52

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge remote-tracking branch 'origin/systematic_sensitivity' into sys…

e2d17c9

…tematic_sensitivity

Renaming proposal.

ad41c47

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'systematic_sensitivity' of https://github.com/powsybl/p…

8e069f4

…owsybl-open-loadflow into systematic_sensitivity

annetill changed the title ~~[WIP] Add systematic analysis with contingencies to sensitivity analysis~~ Add systematic analysis with contingencies to sensitivity analysis Jan 11, 2021

annetill requested a review from geofjamg January 11, 2021 15:14

geofjamg approved these changes Jan 12, 2021

View reviewed changes

annetill self-requested a review January 12, 2021 12:52

annetill approved these changes Jan 12, 2021

View reviewed changes

geofjamg merged commit dcb4d25 into master Jan 12, 2021

geofjamg deleted the systematic_sensitivity branch January 12, 2021 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add systematic analysis with contingencies to sensitivity analysis #189

Add systematic analysis with contingencies to sensitivity analysis #189

Djazouli commented Dec 17, 2020

annetill Dec 22, 2020 •

edited

Loading

annetill Jan 8, 2021

annetill Jan 8, 2021

annetill Jan 8, 2021

Djazouli Jan 8, 2021

annetill Jan 8, 2021

annetill Jan 8, 2021 •

edited

Loading

geofjamg Jan 11, 2021

geofjamg Jan 11, 2021

sonarqubecloud bot commented Jan 11, 2021

Add systematic analysis with contingencies to sensitivity analysis #189

Add systematic analysis with contingencies to sensitivity analysis #189

Conversation

Djazouli commented Dec 17, 2020

annetill Dec 22, 2020 • edited Loading

Choose a reason for hiding this comment

annetill Jan 8, 2021

Choose a reason for hiding this comment

annetill Jan 8, 2021

Choose a reason for hiding this comment

annetill Jan 8, 2021

Choose a reason for hiding this comment

Djazouli Jan 8, 2021

Choose a reason for hiding this comment

annetill Jan 8, 2021

Choose a reason for hiding this comment

annetill Jan 8, 2021 • edited Loading

Choose a reason for hiding this comment

geofjamg Jan 11, 2021

Choose a reason for hiding this comment

geofjamg Jan 11, 2021

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 11, 2021

annetill Dec 22, 2020 •

edited

Loading

annetill Jan 8, 2021 •

edited

Loading