Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even-Shiloach corrections #192

Merged
merged 7 commits into from
Jan 8, 2021
Merged

Even-Shiloach corrections #192

merged 7 commits into from
Jan 8, 2021

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 6, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Wrong set of connected components (some connected components missing) in 3 cases:

  • tripled (or more) edge between two vertices
  • when removing several edges which each create a new connected component
  • corner case of removing a "dangling" edge (between a non-null vertex and a null vertex)

What is the new behavior (if this is a feature change)?
Correct set of connected components

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_corrections branch from 2a64582 to 147ea2f Compare January 6, 2021 09:29
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_corrections branch 2 times, most recently from 1ae6768 to b442ee1 Compare January 6, 2021 11:28
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_corrections branch from b442ee1 to f8bf3dc Compare January 6, 2021 12:37
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_corrections branch from f8bf3dc to 69a2008 Compare January 6, 2021 12:53
Even if not undone so far, this reflects better what's done in process B, and will be useful later

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@annetill annetill requested a review from geofjamg January 7, 2021 19:14
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit a81aaff into master Jan 8, 2021
@geofjamg geofjamg deleted the evenshiloach_corrections branch January 8, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants