Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even-Shiloach optimisation #193

Merged
merged 8 commits into from
Jan 11, 2021
Merged

Even-Shiloach optimisation #193

merged 8 commits into from
Jan 11, 2021

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 8, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce?
Computation time optimisation

What is the current behavior? (You can also link to an open issue here)
Slow reset when using Even-Shiloach decremental connectivity algorithm

What is the new behavior (if this is a feature change)?
A lot quicker Even-Shiloach implementation: on the test network containing 10k branches, creating LfContingencies from all possible contingencies now takes about 300ms instead of 15s.

Does this PR introduce a breaking change or deprecate an API?
No

Other information:
Helps to a (very) small extent improving the security analysis computation time (issue #129)

@flo-dup flo-dup changed the base branch from master to evenshiloach_corrections January 8, 2021 09:13
Base automatically changed from evenshiloach_corrections to master January 8, 2021 10:00
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_optim branch 2 times, most recently from ae7d013 to 15a59b6 Compare January 8, 2021 12:54
@flo-dup flo-dup changed the title Even-Shiloach optimisation [WIP] Even-Shiloach optimisation Jan 8, 2021
With corresponding unit test

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the evenshiloach_optim branch from 3928270 to 8b58d56 Compare January 8, 2021 14:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup changed the title [WIP] Even-Shiloach optimisation Even-Shiloach optimisation Jan 8, 2021
@flo-dup flo-dup requested a review from geofjamg January 8, 2021 14:19
@geofjamg geofjamg merged commit d93176a into master Jan 11, 2021
@geofjamg geofjamg deleted the evenshiloach_optim branch January 11, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants