Increase security analysis with temporary limits and violations filter #195

annetill · 2021-01-12T15:54:28Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

Yes, issue: #129

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Expected: current temporary limits.
Expected: a sort on limit violations. There is a rule not to detect violations in state N-1/K if they already exist in state N, expect if they are worst (violation of a limit that has a smaller acceptable duration). For a contingency and for a branch side, if several temporary limit are violated, only the worst one is displayed (the worst one means the smaller acceptable duration). The LimitViolationFilter is not used for the moment.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

src/main/java/com/powsybl/openloadflow/network/LfBranch.java

src/main/java/com/powsybl/openloadflow/network/impl/LfBranchImpl.java

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup · 2021-02-09T17:14:35Z

src/main/java/com/powsybl/openloadflow/network/AbstractLfBranch.java

@@ -21,6 +25,9 @@

    private static final Logger LOGGER = LoggerFactory.getLogger(AbstractLfBranch.class);

+    private static final Comparator<CurrentLimits.TemporaryLimit> TEMPORARY_LIMITS_COMPARATOR =
+        Comparator.comparingDouble(CurrentLimits.TemporaryLimit::getValue).reversed();


I'm wondering, isn't it the same to sort based on descending values as to sort based on ascending acceptableDuration? Then we wouldn't need to sort, as they are already sorted in TemporaryLimitImpl based on ascending acceptableDuration

src/main/java/com/powsybl/openloadflow/network/AbstractLfBranch.java

src/main/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysis.java

annetill · 2021-02-10T09:03:28Z

Now, we have to imagine a post-processing that, for a branch and for s side:

For the base case: keep the limit violation with the more important value ;
For the post-contingency case: keep the limit violation with the more important value and put it in the result only if not present in the base case.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill · 2021-02-12T12:41:52Z

src/main/java/com/powsybl/openloadflow/network/AbstractLfBranch.java

+        SortedSet<LfTemporaryLimit> temporaryLimits = new TreeSet<>(TEMPORARY_LIMITS_COMPARATOR);
+        if (currentLimits != null) {
+            for (CurrentLimits.TemporaryLimit temporaryLimit : currentLimits.getTemporaryLimits()) {
+                double valuePerUnit = temporaryLimit.getValue() != Double.MAX_VALUE ? temporaryLimit.getValue() * bus.getNominalV() / PerUnit.SB : Double.MAX_VALUE;


Double.NaN?

Indeed I think that we don't need to make the distinction between temporary and permanent limit. The permanent limit is just a temporary limit with infinite duration time. And with that, the comparator works for all limits and it will ease the post processing on limit violations.

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

The temporary limits are already sorted Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill · 2021-03-12T16:03:32Z

src/main/java/com/powsybl/openloadflow/network/AbstractLfBranch.java

+        if (currentLimits != null) {
+            double toPerUnit = bus.getNominalV() / PerUnit.SB;
+            for (LoadingLimits.TemporaryLimit temporaryLimit : currentLimits.getTemporaryLimits()) {
+                double valuePerUnit = temporaryLimit.getValue() != Double.MAX_VALUE ? temporaryLimit.getValue() * toPerUnit : Double.MAX_VALUE;


Why the default value for limit value is Double.MAX_VALUE and not NaN?

Because Double.NaN is not supported as value in the implementation TemporaryLimitAdder of powsybl-iidm-impl. Do you think we should still support a NaN value?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

annetill · 2021-03-15T10:56:23Z

src/main/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysis.java

        if (postContingencyComputationOk) {
            detectViolations(
                network.getBranches().stream().filter(b -> !lfContingency.getBranches().contains(b)),
                network.getBuses().stream().filter(b -> !lfContingency.getBuses().contains(b)),
                postContingencyLimitViolations);
        }

+        preContingencyLimitViolations.forEach((subjectSideId, preContingencyViolation) -> {
+            LimitViolation postContingencyViolation = postContingencyLimitViolations.get(subjectSideId);
+            if (postContingencyViolation != null && postContingencyViolation.getAcceptableDuration() >= preContingencyViolation.getAcceptableDuration()) {


@geofjamg I think that the comparator should rely on getValue and not on getAcceptableDuration. What do you think ?

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

…than 1.1. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

This reverts commit d369d07. Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

sonarqubecloud · 2021-03-24T07:11:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.2% Coverage
0.0% Duplication

annetill added 5 commits January 12, 2021 16:49

First version of temporary limits management.

374ce4d

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

First import of temporary limits violation detection.

3f3ccbd

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add unit tests.

70e4971

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Fix code smells.

a31825f

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Improvement of temporary limits violation detection.

e552d3a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

flo-dup force-pushed the increase-security-analysis branch from ce756b5 to e552d3a Compare January 19, 2021 09:43

jonenst force-pushed the master branch from 9542f6d to a371a95 Compare January 26, 2021 15:51

Merge branch 'master' into increase-security-analysis

e311bde

flo-dup requested changes Feb 2, 2021

View reviewed changes

Use SortedSet<TemporaryLimit> instead of Map<Integer, Double>

1e0d90e

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup reviewed Feb 9, 2021

View reviewed changes

annetill commented Feb 10, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/AbstractLfBranch.java Outdated Show resolved Hide resolved

annetill commented Feb 10, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysis.java Outdated Show resolved Hide resolved

flo-dup added 2 commits February 10, 2021 18:06

Use of per unit values through LfTemporaryLimit class

8caec0f

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Merge branch 'master' into increase-security-analysis

16b18e3

annetill commented Feb 12, 2021

View reviewed changes

tadam50 and others added 12 commits March 1, 2021 16:43

Add filtering on PostContingeny LimitViolation result list

55b8e15

Signed-off-by: Thomas ADAM <tadam@silicom.fr>

Merge.

150a1a6

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Finish merge.

d0be97a

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Temporary and permanent limits now in one sorted set

2404a5a

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Post/pre-contingency comparison: comparing instead of using comparator

20b32be

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Renaming getTemporaryLimits -> getLimits

0f59cc7

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Returns list instead of sorted set

99066ce

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Unit tests updated

73adfbc

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Add sorting assertions in unit test

017e91f

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Limits: LinkedList instead of SortedSet

9caa75b

The temporary limits are already sorted Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Storing list of limits instead of creating it for each contingency

5f56c30

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Removing unused file

def9b17

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

annetill changed the title ~~[WIP] Increase security analysis~~ Increase security analysis Mar 12, 2021

annetill changed the title ~~Increase security analysis~~ Increase security analysis with temporary limits and violations filter Mar 12, 2021

annetill commented Mar 12, 2021

View reviewed changes

annetill and others added 2 commits March 12, 2021 17:40

Add unit test.

a364ae1

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into increase-security-analysis

128c4b7

annetill requested a review from geofjamg March 12, 2021 16:48

annetill commented Mar 15, 2021

View reviewed changes

annetill and others added 6 commits March 16, 2021 15:27

Trial.

5bf24f3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Only enabled buses can switch PQ to PV or PV to PQ.

94a8cb3

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Remove limit violation for the same limit if value increases of more …

86a4574

…than 1.1. Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Adding comments to post/pre-contingency violations comparison

ff6196f

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

LfLimit -> LfViolationRange

d369d07

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

Revert "LfLimit -> LfViolationRange"

9838e2a

This reverts commit d369d07. Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>

flo-dup force-pushed the increase-security-analysis branch from 2450a99 to 9838e2a Compare March 22, 2021 10:14

annetill added 3 commits March 22, 2021 12:15

Merge.

cdb3d18

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge.

fbe3ab0

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Add comments.

5bed57e

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

geofjamg approved these changes Mar 23, 2021

View reviewed changes

annetill and others added 4 commits March 23, 2021 15:30

Fix.

01439fa

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>

Merge branch 'master' into increase-security-analysis

fde864f

Merge branch 'master' into increase-security-analysis

bdefa00

Merge branch 'master' into increase-security-analysis

b3ba9c7

annetill merged commit cb70cc1 into master Mar 24, 2021

annetill deleted the increase-security-analysis branch March 24, 2021 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase security analysis with temporary limits and violations filter #195

Increase security analysis with temporary limits and violations filter #195

annetill commented Jan 12, 2021 •

edited

Loading

flo-dup Feb 9, 2021

annetill commented Feb 10, 2021

annetill Feb 12, 2021

annetill Mar 9, 2021

annetill Mar 12, 2021 •

edited

Loading

flo-dup Mar 15, 2021

annetill Mar 15, 2021

sonarqubecloud bot commented Mar 24, 2021

Increase security analysis with temporary limits and violations filter #195

Increase security analysis with temporary limits and violations filter #195

Conversation

annetill commented Jan 12, 2021 • edited Loading

flo-dup Feb 9, 2021

Choose a reason for hiding this comment

annetill commented Feb 10, 2021

annetill Feb 12, 2021

Choose a reason for hiding this comment

annetill Mar 9, 2021

Choose a reason for hiding this comment

annetill Mar 12, 2021 • edited Loading

Choose a reason for hiding this comment

flo-dup Mar 15, 2021

Choose a reason for hiding this comment

annetill Mar 15, 2021

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 24, 2021

annetill commented Jan 12, 2021 •

edited

Loading

annetill Mar 12, 2021 •

edited

Loading