Participating parameter in LfBus/LfGenerator #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
changed the title
geofjamg
reviewed
Feb 2, 2021
There was a problem hiding this comment.
This is confusing with the participating of LfGenerator. What does it means compared to the generator one?
If the idea is to use it when a bus is not anymore in the component to skip it in the active power participation, why not just call it like 'separated' or 'disconnected' or something related to the fact it is not attached to the component?
2 tasks
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
geofjamg
approved these changes
Feb 2, 2021
flo-dup
commented
Feb 2, 2021
| @@ -105,6 +105,7 @@ SecurityAnalysisResult runSync(SecurityAnalysisParameters securityAnalysisParame | |||
|
|
|||
| LoadFlowParameters lfParameters = securityAnalysisParameters.getLoadFlowParameters(); | |||
| OpenLoadFlowParameters lfParametersExt = OpenLoadFlowProvider.getParametersExt(securityAnalysisParameters.getLoadFlowParameters()); | |||
| lfParametersExt.setThrowsExceptionInCaseOfSlackDistributionFailure(false); //FIXME | |||
There was a problem hiding this comment.
Could you still add a description to this fixme?
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
One should keep track through lists if a LfGenerator / LfBus is participating or not to power control
What is the new behavior (if this is a feature change)?
LfGenerator and LfBus have a parameter to indicate if they participate or not
Does this PR introduce a breaking change or deprecate an API?
No