Fix DC equations when a1 is a variable #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Djazouli
approved these changes
Feb 3, 2021
annetill
reviewed
Feb 3, 2021
| @@ -58,7 +58,11 @@ public void update(double[] x) { | |||
| double ph2 = x[ph2Var.getRow()]; | |||
| double a1 = a1Var != null ? x[a1Var.getRow()] : branch.getPiModel().getA1(); | |||
| p1 = calculate(ph1, ph2, a1); | |||
| rhs = -power * (A2 - a1); | |||
| if (a1Var == null) { | |||
There was a problem hiding this comment.
In ac module, you have introduced the notion of active variable. I think that we have to test if (a1Var != null && a1Var.isActive()), as we do in ac module.
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When a1 is considered as a variable the rhs, so the part of the equation which has to be moved to right hand side is not correct.
What is the new behavior (if this is a feature change)?
rhs has been fixed
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)