Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method dispatchQ #227

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Fix method dispatchQ #227

merged 4 commits into from
Mar 2, 2021

Conversation

frigaux
Copy link
Contributor

@frigaux frigaux commented Feb 16, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#218
Before trying to make test running successfull, we should check that 218 is really an issue.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Build failure according to issue 218

…help fixing issue 218

Build should fail with this message (issue 218)
[ERROR] Failures:
[ERROR]   LfBusImplTest.updateGeneratorsStateTest:93 sum of generators calculatedQ should be equals to qToDispatch ==> expected: <-6.412103131789854> but was: <-7.4807869870881625>

Signed-off-by: Fabien Rigaux <fabien.rigaux@free.fr>
@frigaux frigaux requested a review from annetill February 16, 2021 10:53
annetill and others added 2 commits March 2, 2021 07:24
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title Junit test design to help understanding issue 218 Fix method qToDispatch Mar 2, 2021
@annetill annetill changed the title Fix method qToDispatch Fix method dispatchQ Mar 2, 2021
@annetill annetill requested a review from geofjamg March 2, 2021 10:03
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 7ccf682 into master Mar 2, 2021
@geofjamg geofjamg deleted the issue_218_dispatchQ branch March 2, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants