Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min impedance cut #235

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Fix min impedance cut #235

merged 4 commits into from
Sep 28, 2021

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Mar 2, 2021

Signed-off-by: Geoffroy Jamgotchian geoffroy.jamgotchian@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg changed the title Fix min impedance cut [WIP] Fix min impedance cut Mar 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

annetill and others added 2 commits September 9, 2021 14:30
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@geofjamg geofjamg changed the title [WIP] Fix min impedance cut Fix min impedance cut Sep 27, 2021
@geofjamg
Copy link
Member Author

@annetill do you think this PR relevant?
The idea was:

  • to cut not only the current tap but all
  • to cut on impedance module and keep loss angle

@geofjamg geofjamg requested a review from annetill September 27, 2021 19:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill
Copy link
Member

@annetill do you think this PR relevant?
The idea was:

  • to cut not only the current tap but all
  • to cut on impedance module and keep loss angle

Yes, it is better the way you fix this.

@annetill annetill merged commit 7d65116 into master Sep 28, 2021
@annetill annetill deleted the min_z_fix branch September 28, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants