Change disconnected sensitivities management #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted component Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Djazouli
force-pushed
the
disconnected_sensitivities_management
branch
from
59b593d to
393137d
Compare
geofjamg
reviewed
Mar 3, 2021
| enum Status { | ||
| VALID, | ||
| SKIP, | ||
| NULL |
There was a problem hiding this comment.
You don't need this enum value, just use a null status
There was a problem hiding this comment.
For me, null and Status.NULL would represent two different things:
- If the status is Status.NULL, it means that the value for this sensitivity factor will be null (0), because it is a sensitivity on a disconnected branch
- if the status is null (meaning: the sensitivity factor has no value), then this is a bug
There was a problem hiding this comment.
So here NULL means zero. this make me think it is NULL as null in Java so an enum with a mix of business and technical values which is a bad practice
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
|
@Djazouli I just tested, it works very well, but it is quite verbose. When a transformer is disconnected and is the variable of many factors we end up with as many warn as functions for this variables. Maybe we can in this skip have just one warning saying: "skipping all factors with variable ..." ? |
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
geofjamg
approved these changes
Mar 4, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restDo not throw an error if we are asking a sensitivity on a component that is not in the network