-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC sensitivity analysis: fix contingency involving phase tap changer #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com> Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Djazouli
force-pushed
the
fix_contingency_on_transformer_dc
branch
from
March 4, 2021 18:19
4530fd3
to
5454e66
Compare
annetill
reviewed
Mar 5, 2021
@@ -109,6 +107,15 @@ public DcLoadFlowResult run() { | |||
.forEach(column -> targetVector[column] = 0); | |||
} | |||
|
|||
if (!removedBranches.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the comment just above and add a comment here to explain maybe.
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
…transformer_dc_partial_merge # Conflicts: # src/main/java/com/powsybl/openloadflow/dc/DcLoadFlowEngine.java # src/main/java/com/powsybl/openloadflow/graph/EvenShiloachGraphDecrementalConnectivity.java # src/main/java/com/powsybl/openloadflow/graph/MinimumSpanningTreeGraphDecrementalConnectivity.java # src/main/java/com/powsybl/openloadflow/graph/NaiveGraphDecrementalConnectivity.java # src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java # src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java
…ix_contingency_on_transformer_dc Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
annetill
approved these changes
Mar 9, 2021
Kudos, SonarCloud Quality Gate passed! |
annetill
changed the title
Fix contingency on transformer dc
DC sensitivity analysis: fix contingency involving phase tap changer
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)