Fix bug on DC loadflow when using multiple contingencies with transformers #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontingency (they were set to 0) Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
annetill
reviewed
Mar 11, 2021
| private final DiscreteVoltageControl voltageControl; | ||
|
|
||
| public BranchState(LfBranch b) { | ||
| PiModel piModel = b.getPiModel(); |
There was a problem hiding this comment.
Can you start with just a1 and r1 ? For the controls, it will be more complex (and we don't know how to do).
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
annetill
reviewed
Mar 12, 2021
| r1 = piModel.getR1(); | ||
| } | ||
|
|
||
| public void restoreBranchActiveState(LfBranch branch) { |
There was a problem hiding this comment.
Can you here start with only restoreBranchState ? Sorry for the delay of the remark...
annetill
reviewed
Mar 12, 2021
| * Set the branch states based on the given map of states | ||
| * @param branchStates the map containing the branches states, indexed by branches | ||
| */ | ||
| public static void restoreBranchActiveStates(Map<LfBranch, BranchState> branchStates) { |
annetill
approved these changes
Mar 12, 2021
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)