Fix default parameter loading #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
geofjamg
reviewed
Mar 30, 2021
| @@ -21,7 +21,7 @@ | |||
| public static final SlackBusSelector SLACK_BUS_SELECTOR_DEFAULT_VALUE = new MostMeshedSlackBusSelector(); | |||
|
|
|||
| public static final String THROWS_EXCEPTION_IN_CASE_OF_SLACK_DISTRIBUTION_FAILURE_PARAM_NAME = "throwsExceptionInCaseOfSlackDistributionFailure"; | |||
| public static final boolean THROWS_EXCEPTION_IN_CASE_OF_SLACK_DISTRIBUTION_FAILURE_DEFAULT_VALUE = true; | |||
| public static final boolean THROWS_EXCEPTION_IN_CASE_OF_SLACK_DISTRIBUTION_FAILURE_DEFAULT_VALUE = false; | |||
There was a problem hiding this comment.
I don't known if it should be the default behaviour. I think we did that because of network with multiple synchronous components. Very often there is no way to fully distribute slack on small synchronous components and we don't want the simulation to fail.
There was a problem hiding this comment.
Yes but with this modification, the default behavior is to log an error.
geofjamg
approved these changes
Mar 30, 2021
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restN/A
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When we run OLF without specific parameters, the parameters are not read from the config.yml file. The default constructor is used.
What is the new behavior (if this is a feature change)?
Load the OLF parameters from config.yml.
The default value for
throwsExceptionInCaseOfSlackDistributionFailurealso changed tofalse. @geofjamg do you agree with that change?Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)