manage additional factors #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djazouli
force-pushed
the
additional_factors
branch
2 times, most recently
from
3787fa4 to
737f518
Compare
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Djazouli
force-pushed
the
additional_factors
branch
from
737f518 to
335b624
Compare
# Conflicts: # src/test/java/com/powsybl/openloadflow/sensi/dc/DcSensitivityAnalysisContingenciesTest.java
geofjamg
reviewed
Apr 14, 2021
flo-dup
reviewed
Apr 15, 2021
src/main/java/com/powsybl/openloadflow/sensi/SensitivityFactorReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java
Show resolved
Hide resolved
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
…bl-open-loadflow into additional_factors Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
flo-dup
requested changes
Apr 19, 2021
| @@ -46,50 +46,54 @@ public SensitivityFactorReaderAdapter(Network network, SensitivityFactorsProvide | |||
|
|
|||
| @Override | |||
| public void read(Handler handler) { | |||
| ContingencyContext commonContingencyContext = new ContingencyContext(ContingencyContextType.ALL, null); | |||
There was a problem hiding this comment.
Just as small improvement, would be better to use 3 static methods to create ContingencyContexts (ContingencyContext.createAllContingencyContext(), ContingencyContext.createNoneContingencyContext(), ContingencyContext.createSpecificContingencyContext(String id))
Signed-off-by: Gael Macherel <gael.macherel@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gael Macherel gael.macherel@artelys.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)