DC sensitivity analysis: bug fix in case of contingency losing a participating element #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
reviewed
Apr 13, 2021
| @@ -730,8 +730,7 @@ public void analyse(Network network, List<PropagatedContingency> contingencies, | |||
| slackParticipationByBusForThisConnectivity = Collections.singletonMap(lfNetwork.getBusById(lfNetwork.getSlackBus().getId()), -1d); | |||
| } | |||
|
|
|||
| factorsStates.reset(); // avoid creating a new matrix to avoid buffer allocation time | |||
| fillRhsSensitivityVariable(equationSystem, factorGroups, factorStateForThisConnectivity, slackParticipationByBusForThisConnectivity); | |||
| factorStateForThisConnectivity = initFactorsRhs(equationSystem, factorGroups, slackParticipationByBusForThisConnectivity); | |||
There was a problem hiding this comment.
I understand you fix. I wonder if there is a way to class the contingencies treatment in order to have in one side contingencies that don't affect the slack participation and in the other side contingencies that affect it.
annetill
approved these changes
Apr 13, 2021
annetill
changed the title
flo-dup
pushed a commit
that referenced
this pull request
Apr 13, 2021
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gael Macherel gael.macherel@artelys.com
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a bugfix
What is the current behavior? (You can also link to an open issue here)
Currently, while running a DC sensitivity analysis, the following bug can occur:
If there are several contingencies, and one of them changes the slack distribution (by losing generators, for example), then it will change the factorStates, and the basecase sensitivity, for all following contingencies. The one that does not change the participation will then be wrong
What is the new behavior (if this is a feature change)?
We do not overwrite the factorStates matrix, but create a new one.