Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity on the active power setpoint of an HVDC line #277

Merged
merged 22 commits into from
May 18, 2021
Merged

Conversation

Djazouli
Copy link
Contributor

Signed-off-by: Gael Macherel gael.macherel@artelys.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
@Djazouli
Copy link
Contributor Author

Does not work in AC currently, I'm trying to figure out why

@Djazouli Djazouli changed the title Sensi on ActivePowerSetpoint on HVDC line [WIP] Sensi on ActivePowerSetpoint on HVDC line Apr 15, 2021
@Djazouli Djazouli requested a review from annetill April 15, 2021 15:01
double sensiChange = 10e-4;
// test injection increase on loads
Network network = HvdcNetworkFactory.createNetworkWithGenerators();
network.getGeneratorStream().forEach(gen -> gen.setMaxP(2 * gen.getMaxP()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this line on generator max P?

Djazouli and others added 4 commits April 16, 2021 11:41
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Gael Macherel <gael.macherel@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
sensiProvider.run(network, VariantManagerConstants.INITIAL_VARIANT_ID, Collections.singletonList(new Contingency("l25", new BranchContingency("l25"))),
sensiParameters, reader, hvdcWriter);

// FIXME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remplaced LCCs by VSCs but it still does not work with distributed slack.

annetill and others added 2 commits April 26, 2021 11:16
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill
Copy link
Member

@geofjamg I have after merge two unit tests that failed. The error is not obvious, so if you have any idea, it would be really helpful. Thanks a lot!

Djazouli and others added 4 commits April 26, 2021 18:49
Signed-off-by: Gael Macherel <gael.macherel@gmail.com>
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysis.java
#	src/test/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysisTest.java
#	src/test/java/com/powsybl/openloadflow/sensi/dc/DcSensitivityAnalysisContingenciesTest.java
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill changed the title [WIP] Sensi on ActivePowerSetpoint on HVDC line Sensitivity on the active power setpoint of an HVDC line Apr 27, 2021
geofjamg and others added 10 commits April 27, 2021 08:52
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
# Conflicts:
#	src/test/java/com/powsybl/openloadflow/sensi/AbstractSensitivityAnalysisTest.java
Signed-off-by: Gael Macherel <gael.macherel@gmail.com>
Signed-off-by: Gael Macherel <gael.macherel@gmail.com>
Signed-off-by: Gael Macherel <gael.macherel@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 83d5c9c into master May 18, 2021
@annetill annetill deleted the hvdc_sensi branch May 18, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants